From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MHucq-0004EA-2O for mharc-grub-devel@gnu.org; Sat, 20 Jun 2009 03:04:32 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHuco-0004C3-4W for grub-devel@gnu.org; Sat, 20 Jun 2009 03:04:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHucj-00046S-OG for grub-devel@gnu.org; Sat, 20 Jun 2009 03:04:29 -0400 Received: from [199.232.76.173] (port=58120 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHucj-00046O-Iu for grub-devel@gnu.org; Sat, 20 Jun 2009 03:04:25 -0400 Received: from mx20.gnu.org ([199.232.41.8]:8909) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MHuci-0001mv-SG for grub-devel@gnu.org; Sat, 20 Jun 2009 03:04:25 -0400 Received: from mailout09.t-online.de ([194.25.134.84]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MHuch-0006AT-O7 for grub-devel@gnu.org; Sat, 20 Jun 2009 03:04:23 -0400 Received: from fwd09.aul.t-online.de by mailout09.t-online.de with smtp id 1MHucf-00055M-01; Sat, 20 Jun 2009 09:04:21 +0200 Received: from [10.3.2.2] (Z4aPdcZTQhQ2ZS2nA8pAXanH73LqVnahmA6pRBH-H0WxK+uzbYYp-3IvCc++KSeQYO@[217.235.231.205]) by fwd09.aul.t-online.de with esmtp id 1MHucX-1ooAxU0; Sat, 20 Jun 2009 09:04:13 +0200 Message-ID: <4A3C89ED.9020000@t-online.de> Date: Sat, 20 Jun 2009 09:04:13 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090403 SeaMonkey/1.1.16 MIME-Version: 1.0 To: The development of GRUB 2 References: <4A3BEF72.1050005@t-online.de> <1245447191.672.5.camel@mj> In-Reply-To: <1245447191.672.5.camel@mj> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: Z4aPdcZTQhQ2ZS2nA8pAXanH73LqVnahmA6pRBH-H0WxK+uzbYYp-3IvCc++KSeQYO X-TOI-MSGID: e67d4bd3-a555-4c53-8a19-d915cc0dada1 X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [2342] 2009-06-18 Vladimir Serbinenko X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2009 07:04:30 -0000 Pavel Roskin wrote: > On Fri, 2009-06-19 at 22:05 +0200, Christian Franke wrote: > >> This was the AC_MSG_RESULT(...) for the >> AC_MSG_CHECKING([for option to link raw image]) >> which is still present for the "$grub_cv_apple_target_cc" != "yes" case. >> >> I would suggest to move the AC_MSG_CHECKING outside the 'if >> "$grub_cv_apple_target_cc" = "yes" ... fi' and re-add the AC_MSG_RESULT. >> > > Thanks for pointing it out. Actually, the message is not needed at all. > There is no "checking" that needs to be communicated to the user. It > would be appropriate if configure was running a compiler or looked for > some tool in the PATH. In this case, it's just shell variable > assignments with on test for a file. > > I would prefer an output here even if the test done isn't a 'real' configure check. Would also make sense when we later apply your 'Use common linker script for all i386-pc systems' suggestion. But if you want to remove this messages it is also fine with me. Same would then possibly also apply to the AC_MSG_CHECKING([for command to convert module to ELF format]) a few lines below. -- Regards, Christian Franke