From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIJsc-00038P-AK for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIJsW-000372-K3 for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:29 -0400 Received: from [199.232.76.173] (port=57459 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIJsW-00036m-0a for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:24 -0400 Received: from mail-ew0-f223.google.com ([209.85.219.223]:54614) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIJsV-00032c-CO for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:23 -0400 Received: by ewy23 with SMTP id 23so682833ewy.34 for ; Sun, 21 Jun 2009 03:02:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> Date: Sun, 21 Jun 2009 12:02:21 +0200 Message-ID: <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> From: Filip Navara Content-Type: multipart/alternative; boundary=0016364d226183c749046cd8dad6 Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel --0016364d226183c749046cd8dad6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguori wrote: > From: Anthony Liguori > > Signed-off-by: Anthony Liguori > > diff --git a/Makefile b/Makefile > index 3177616..209b21f 100644 > --- a/Makefile > +++ b/Makefile > @@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h > > sdl.o: sdl.c keymaps.h sdl_keysym.h > > -sdl.o audio/sdlaudio.o: CFLAGS += $(SDL_CFLAGS) > +sdl.o audio/sdlaudio.o baum.o: CFLAGS += $(SDL_CFLAGS) > > acl.o: acl.h acl.c > > diff --git a/Makefile.target b/Makefile.target > index 27de4b9..0159bf7 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -730,6 +730,8 @@ LDFLAGS+=-p > main.o: CFLAGS+=-p > endif > > +vl.o: CFLAGS+=$(SDL_CFLAGS) > + > vl.o: qemu-options.h > > monitor.o: qemu-monitor.h > > > Please note that this commits breaks the Win32 port in several ways. First problem is the SDL_main definition as already pointed out on the mailing list. The other problem is that default mingw32 builds of SDL redirect stderr/stdout through the SDL_main hack (and in incorrect way too, but I will leave that for the SDL folks), so it's nearly impossible to get console output - ie. error messages or help. The only workaround I know is to build SDL with the --disable-stdio-redirect, which is a bit annoying. Best regards, Filip Navara --0016364d226183c749046cd8dad6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguor= i <aliguori@us.= ibm.com> wrote:
From: Anthony Liguori <aliguori@u= s.ibm.com>

Signed-off-by: Anthony Liguori <a= liguori@us.ibm.com>

diff --git a/Makefile b/Makefile
index 3177616..209b21f 100644
--- a/Makefile
+++ b/Makefile
@@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h

=A0sdl.o: sdl.c keymaps.h sdl_keysym.h

-sdl.o audio/sdlaudio.o: CFLAGS +=3D $(SDL_CFLAGS)
+sdl.o audio/sdlaudio.o baum.o: CFLAGS +=3D $(SDL_CFLAGS)

=A0acl.o: acl.h acl.c

diff --git a/Makefile.target b/Makefile.target
index 27de4b9..0159bf7 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -730,6 +730,8 @@ LDFLAGS+=3D-p
=A0main.o: CFLAGS+=3D-p
=A0endif

+vl.o: CFLAGS+=3D$(SDL_CFLAGS)
+
=A0vl.o: qemu-options.h

=A0monitor.o: qemu-monitor.h



Please note that this commits breaks the Win32 = port in several ways. First problem is the SDL_main definition as already p= ointed out on the mailing list. The other problem is that default mingw32 b= uilds of SDL redirect stderr/stdout through the SDL_main hack (and in incor= rect way too, but I will leave that for the SDL folks), so it's nearly = impossible to get console output - ie. error messages or help.

The only workaround I know is to build SDL with the --d= isable-stdio-redirect, which is a bit annoying.

Be= st regards,
Filip Navara
--0016364d226183c749046cd8dad6-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIK5U-0006P5-RZ for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIK5Q-0006N4-8T for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:48 -0400 Received: from [199.232.76.173] (port=46074 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIK5P-0006Mr-3B for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:43 -0400 Received: from mail-ew0-f223.google.com ([209.85.219.223]:35823) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIK5O-0005F6-HK for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:42 -0400 Received: by ewy23 with SMTP id 23so686863ewy.34 for ; Sun, 21 Jun 2009 03:15:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> Date: Sun, 21 Jun 2009 12:15:41 +0200 Message-ID: <5b31733c0906210315w60a40e85r3e5a11372c8ddd9@mail.gmail.com> From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel On Sun, Jun 21, 2009 at 12:02 PM, Filip Navara wro= te: > > On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguori w= rote: >> >> From: Anthony Liguori >> >> Signed-off-by: Anthony Liguori >> >> diff --git a/Makefile b/Makefile >> index 3177616..209b21f 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h >> >> =A0sdl.o: sdl.c keymaps.h sdl_keysym.h >> >> -sdl.o audio/sdlaudio.o: CFLAGS +=3D $(SDL_CFLAGS) >> +sdl.o audio/sdlaudio.o baum.o: CFLAGS +=3D $(SDL_CFLAGS) >> >> =A0acl.o: acl.h acl.c >> >> diff --git a/Makefile.target b/Makefile.target >> index 27de4b9..0159bf7 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -730,6 +730,8 @@ LDFLAGS+=3D-p >> =A0main.o: CFLAGS+=3D-p >> =A0endif >> >> +vl.o: CFLAGS+=3D$(SDL_CFLAGS) >> + >> =A0vl.o: qemu-options.h >> >> =A0monitor.o: qemu-monitor.h >> >> > > Please note that this commits breaks the Win32 port in several ways. Firs= t problem is the SDL_main definition as already pointed out on the mailing = list. The other problem is that default mingw32 builds of SDL redirect stde= rr/stdout through the SDL_main hack (and in incorrect way too, but I will l= eave that for the SDL folks), so it's nearly impossible to get console outp= ut - ie. error messages or help. > The only workaround I know is to build SDL with the --disable-stdio-redir= ect, which is a bit annoying. Or rather "./configure=A0--enable-stdio-redirect=3Dno". F. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIWjB-0001Yx-1Y for qemu-devel@nongnu.org; Sun, 21 Jun 2009 19:45:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIWj6-0001Yl-L2 for qemu-devel@nongnu.org; Sun, 21 Jun 2009 19:45:36 -0400 Received: from [199.232.76.173] (port=42716 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIWj6-0001Yi-FT for qemu-devel@nongnu.org; Sun, 21 Jun 2009 19:45:32 -0400 Received: from mail-yx0-f192.google.com ([209.85.210.192]:37289) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIWj6-0006fg-1D for qemu-devel@nongnu.org; Sun, 21 Jun 2009 19:45:32 -0400 Received: by yxe30 with SMTP id 30so4164328yxe.4 for ; Sun, 21 Jun 2009 16:45:30 -0700 (PDT) Message-ID: <4A3EC618.2000200@codemonkey.ws> Date: Sun, 21 Jun 2009 18:45:28 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> In-Reply-To: <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: qemu-devel Filip Navara wrote: > > Please note that this commits breaks the Win32 port in several ways. > First problem is the SDL_main definition as already pointed out on the > mailing list. The other problem is that default mingw32 builds of SDL > redirect stderr/stdout through the SDL_main hack (and in incorrect way > too, but I will leave that for the SDL folks), so it's nearly > impossible to getconsole output - ie. error messages or help. I have a fix in queue, but... For mingw32 we don't want to use SDL_main? But we want to use it for OS X? Regards, Anthony Liguori From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIbfl-0003hJ-Da for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:02:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIbfj-0003h7-AY for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:02:24 -0400 Received: from [199.232.76.173] (port=33147 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIbfj-0003h4-5E for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:02:23 -0400 Received: from ey-out-1920.google.com ([74.125.78.147]:19514) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIbfi-0003qJ-Ky for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:02:22 -0400 Received: by ey-out-1920.google.com with SMTP id 3so281749eyh.4 for ; Sun, 21 Jun 2009 22:02:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4A3EC618.2000200@codemonkey.ws> References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> <4A3EC618.2000200@codemonkey.ws> Date: Mon, 22 Jun 2009 07:02:21 +0200 Message-ID: <5b31733c0906212202h2e77804aq7e856f1dd2f016e4@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel On Mon, Jun 22, 2009 at 1:45 AM, Anthony Liguori wrote: > Filip Navara wrote: >> >> Please note that this commits breaks the Win32 port in several ways. First >> problem is the SDL_main definition as already pointed out on the mailing >> list. The other problem is that default mingw32 builds of SDL redirect >> stderr/stdout through the SDL_main hack (and in incorrect way too, but I >> will leave that for the SDL folks), so it's nearly impossible to getconsole >> output - ie. error messages or help. > > I have a fix in queue, but... > > For mingw32 we don't want to use SDL_main? I guess a cleaner approach would be to use SDL_main to keep the code simple and portable. I've seen some crashes in the the past that could be related to the DirectX initialization in the SDL's main wrapper. On the other hand it requires a custom SDL build (only libSDLmain.a, not the sdl.dll) and that should be documented at least. > But we want to use it for OS X? For OS X it's absolutely necessary, it initializes the QuickDraw libraries. Best regards, Filip Navara From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIbub-0002G1-Ve for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIbuW-00029g-Mk for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:44 -0400 Received: from [199.232.76.173] (port=49738 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIbuW-00029d-Eb for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:40 -0400 Received: from mail-fx0-f209.google.com ([209.85.220.209]:48100) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIbuV-0001SS-7n for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:40 -0400 Received: by fxm5 with SMTP id 5so2558540fxm.34 for ; Sun, 21 Jun 2009 22:17:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5b31733c0906212202h2e77804aq7e856f1dd2f016e4@mail.gmail.com> References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> <4A3EC618.2000200@codemonkey.ws> <5b31733c0906212202h2e77804aq7e856f1dd2f016e4@mail.gmail.com> Date: Mon, 22 Jun 2009 07:17:38 +0200 Message-ID: <5b31733c0906212217m196bd22cm58b525df02906325@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel On Mon, Jun 22, 2009 at 7:02 AM, Filip Navara wrote: > On Mon, Jun 22, 2009 at 1:45 AM, Anthony Liguori wrote: >> Filip Navara wrote: >>> >>> Please note that this commits breaks the Win32 port in several ways. First >>> problem is the SDL_main definition as already pointed out on the mailing >>> list. The other problem is that default mingw32 builds of SDL redirect >>> stderr/stdout through the SDL_main hack (and in incorrect way too, but I >>> will leave that for the SDL folks), so it's nearly impossible to getconsole >>> output - ie. error messages or help. >> >> I have a fix in queue, but... >> >> For mingw32 we don't want to use SDL_main? > > I guess a cleaner approach would be to use SDL_main to keep the code > simple and portable. I've seen some crashes in the the past that could > be related to the DirectX initialization in the SDL's main wrapper. On > the other hand it requires a custom SDL build (only libSDLmain.a, not > the sdl.dll) and that should be documented at least. > >> But we want to use it for OS X? > > For OS X it's absolutely necessary, it initializes the QuickDraw libraries. I've checked the latest SDL source code in their svn since the official SDL release (1.2.13) is two years old already. SDL_main for OS X has been removed completely and on Win32 it no longer does any of the nasty stuff it used to do and is unnecessary too. Hopefully an official SDL 1.3 will be released soon and none of the hacks or custom builds will be required anymore... Wishful thinking, I know. Best regards, Filip Navara