Re: [PATCH] [libata] beautify module parameters

[Jeff Garzik <jgarzik@pobox.com>]

Evgeni Golov wrote:
> 1. add defaults to description where possible
> 2. add value definition (off=0, on=1) where missing
> 
> Signed-off-by: Evgeni Golov <sargentd@die-welt.net>
> ---
>  drivers/ata/libata-core.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index ca4d208..da27a3c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -125,11 +125,11 @@ MODULE_PARM_DESC(force, "Force ATA configurations including cable type, link spe
>  
>  static int atapi_enabled = 1;
>  module_param(atapi_enabled, int, 0444);
> -MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off, 1=on)");
> +MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices; on by default (0=off, 1=on)");
>  
>  static int atapi_dmadir = 0;
>  module_param(atapi_dmadir, int, 0444);
> -MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off, 1=on)");
> +MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support; off by default (0=off, 1=on)");

I would prefer a more concise

	"Enable ATAPI DMADIR bridge support (0=off [default], 1=on)"

Regards,

	Jeff