Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?

[Jan Kiszka <jan.kiszka@siemens.com>]

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Hi,
>>
>> I just broke (locally) the slirp statistics. You know: "info slirp".
>> Maybe you don't because they are off by default, and there is even no
>> hidden configure switch to enable them ("#define LOG_ENABLED" or
>> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if
>> there are actually use cases out there.
>>
>> Basically I have three options now:
>>
>>  - drop them completely (would make my nice, 1600-lines dropping slirp
>>    cleanup patch even nicer...)
>>   
> 
> Yes, I'd say drop them.
> 
> What's this "dropping slirp cleanup patch"?  Just something you use
> locally or do you plan on pushing it to the list?

Hacking on slirp, I quickly got sick of of all those "#if 0", "/*
no-longer-used */" or "#ifndef CONFIG_QEMU" and finally dropped them.
It's not a complete cleanup yet (e.g. one would have to go through
slirp_config.h as well, and we need a re-indention run), but it's a start.

Will definitely post it, at latest when my queue is about to overflow
(currently 30 patches, still increasing).

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux