From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIk31-0003WG-Qv for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:58:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIk2v-0003RT-W2 for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:58:58 -0400 Received: from [199.232.76.173] (port=56680 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIk2v-0003R5-RX for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:58:53 -0400 Received: from gecko.sbs.de ([194.138.37.40]:16615) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIk2u-00024j-AC for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:58:52 -0400 Message-ID: <4A3F8E17.3090008@siemens.com> Date: Mon, 22 Jun 2009 15:58:47 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them? References: <4A3F78EE.2090805@siemens.com> <4A3F828A.7000806@codemonkey.ws> In-Reply-To: <4A3F828A.7000806@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel Anthony Liguori wrote: > Jan Kiszka wrote: >> Hi, >> >> I just broke (locally) the slirp statistics. You know: "info slirp". >> Maybe you don't because they are off by default, and there is even no >> hidden configure switch to enable them ("#define LOG_ENABLED" or >> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if >> there are actually use cases out there. >> >> Basically I have three options now: >> >> - drop them completely (would make my nice, 1600-lines dropping slirp >> cleanup patch even nicer...) >> > > Yes, I'd say drop them. > > What's this "dropping slirp cleanup patch"? Just something you use > locally or do you plan on pushing it to the list? Hacking on slirp, I quickly got sick of of all those "#if 0", "/* no-longer-used */" or "#ifndef CONFIG_QEMU" and finally dropped them. It's not a complete cleanup yet (e.g. one would have to go through slirp_config.h as well, and we need a re-indention run), but it's a start. Will definitely post it, at latest when my queue is about to overflow (currently 30 patches, still increasing). Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux