From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MIk5C-000506-BW
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:01:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MIk57-0004yv-2P
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:01:13 -0400
Received: from [199.232.76.173] (port=56751 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MIk55-0004yW-NH
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:01:08 -0400
Received: from mail-fx0-f209.google.com ([209.85.220.209]:59207)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MIk55-0002ZV-93
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:01:07 -0400
Received: by fxm5 with SMTP id 5so2822268fxm.34
	for <qemu-devel@nongnu.org>; Mon, 22 Jun 2009 07:01:04 -0700 (PDT)
Message-ID: <4A3F8E9B.9080704@codemonkey.ws>
Date: Mon, 22 Jun 2009 09:00:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again
References: <1245669483-7076-1-git-send-email-kwolf@redhat.com>
	<4A3F8238.8010903@codemonkey.ws> <4A3F8536.6090906@redhat.com>
In-Reply-To: <4A3F8536.6090906@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

Kevin Wolf wrote:
> Anthony Liguori schrieb:
>   
>> Kevin Wolf wrote:
>>     
>>> Since the patch that suggested it woudl revert qcow2 to writeback caching, in
>>> fact none of the drivers has had cache=off as default any more. This patch
>>> restores the desired behaviour.
>>>   
>>>       
>> When has cache=off ever been the default?
>>
>> Moreover, why would we want to make it the default?  A patch with this 
>> drastic of a change really need a more significant justification in the 
>> change log.
>>     
>
> Hm, you're right. Why is everyone talking about cache=off being default
> except for qcow2? This was confusing me.

qcow2 defaults to writeback whereas everything else defaults to 
writethrough.

So probably taking your patch and s/NOCACHE/CACHE_WT/g would be pretty 
reasonable :-)

Regards,

Anthony Liguori