From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIkqe-0004eT-Gi for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:50:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIkqZ-0004dK-Py for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:50:16 -0400 Received: from [199.232.76.173] (port=53749 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIkqZ-0004dC-KN for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:50:11 -0400 Received: from gecko.sbs.de ([194.138.37.40]:18900) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIkqY-0004tt-VW for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:50:11 -0400 Message-ID: <4A3F9A1E.4000803@siemens.com> Date: Mon, 22 Jun 2009 16:50:06 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them? References: <4A3F78EE.2090805@siemens.com> <4A3F7AE6.5060509@redhat.com> <4A3F805C.4080301@siemens.com> <74A52CFD-33D6-4485-B1E2-6BBE0A1310B5@suse.de> In-Reply-To: <74A52CFD-33D6-4485-B1E2-6BBE0A1310B5@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Avi Kivity , qemu-devel Alexander Graf wrote: > > On 22.06.2009, at 15:00, Jan Kiszka wrote: > >> Avi Kivity wrote: >>> On 06/22/2009 03:28 PM, Jan Kiszka wrote: >>>> I just broke (locally) the slirp statistics. You know: "info slirp". >>>> Maybe you don't because they are off by default, and there is even no >>>> hidden configure switch to enable them ("#define LOG_ENABLED" or >>>> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if >>>> there are actually use cases out there. >>>> >>>> Basically I have three options now: >>>> >>>> - drop them completely (would make my nice, 1600-lines dropping slirp >>>> cleanup patch even nicer...) >>>> - fix them and leave them disabled, maybe adding some >>>> --enable-slirpstats to configure >>>> - fix them, but turn them on by default again so that Joe User is able >>>> to, well, actually look at them >>>> >>>> Feedback appreciated. >>>> >>> >>> I don't see the need for slirp stats. A production deployment is not >>> going to use slirp, and a developer deployment won't need slirp stats. >>> >> >> OK, drop++. >> >> BTW, there is one definitely useful part of "info slirp": the connection >> listing at its end. It's basically what Alexander Graf recently >> contributed, but more complete. I already factored this part out and >> will submit an advanced version, likely under "info usernet" - who knows >> what "slirp" means... > > The cleanup wouldn't drop the connection listing, would it? :-) > That's about the only thing I care about when it comes to any info > regarding slirp. > (qemu) info usernet Protocol[State] FD Source Address Port Dest. Address Port RecvQ SendQ tcp[ESTABLISHED] 20 127.0.0.1 12345 10.0.2.15 22 0 0 tcp[HOST_FORWARD] 17 * 12345 10.0.2.15 22 0 0 udp[HOST_FORWARD] 19 127.0.0.1 10000 10.0.2.15 10000 0 0 udp[230 sec] 18 10.0.2.15 5353 224.0.0.251 5353 0 0 Is that OK? :) Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux