From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sunil Mushran Date: Mon, 22 Jun 2009 13:26:40 -0700 Subject: [Ocfs2-devel] [PATCH 5/5] ocfs2: Disable orphan scanning for local and hard-ro mounts In-Reply-To: <20090622192509.GB3902@mail.oracle.com> References: <1245696007-29494-1-git-send-email-sunil.mushran@oracle.com> <1245696007-29494-2-git-send-email-sunil.mushran@oracle.com> <20090622192509.GB3902@mail.oracle.com> Message-ID: <4A3FE900.30405@oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com Joel Becker wrote: > On Mon, Jun 22, 2009 at 11:40:07AM -0700, Sunil Mushran wrote: >> Local and Hard-RO mounts do not need orphan scanning. > I just realized that we hold the os->os_lock around everything > we do here. The orphan scan state doesn't need to be atomic_t. No we don't hold it across all ops. In ocfs2_orphan_scan_stop(), we set it inactive before taking the mutex. This allows ocfs2_queue_orphan_scan() to bail out without queuing the tasks. The idea is to prevent umount slowdown - as much as possible.