From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Kluin Subject: [PATCH] adfs: remove redundant test on unsigned Date: Mon, 22 Jun 2009 23:09:31 +0200 Message-ID: <4A3FF30B.3080103@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Andrew Morton To: viro@zeniv.linux.org.uk Return-path: Received: from mail-ew0-f210.google.com ([209.85.219.210]:49536 "EHLO mail-ew0-f210.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbZFVTIz (ORCPT ); Mon, 22 Jun 2009 15:08:55 -0400 Received: by ewy6 with SMTP id 6so4957105ewy.37 for ; Mon, 22 Jun 2009 12:08:57 -0700 (PDT) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: unsigned block cannot be less than 0. Signed-off-by: Roel Kluin --- Or should it read if (!create) { if (block >= inode->i_blocks) goto abort_toobig; ... } else if (block >= inode->i_blocks) { adfs_error(inode->i_sb, "block %d < 0", block); return -EIO; } ? diff --git a/fs/adfs/inode.c b/fs/adfs/inode.c index 798cb07..3f57ce4 100644 --- a/fs/adfs/inode.c +++ b/fs/adfs/inode.c @@ -19,9 +19,6 @@ static int adfs_get_block(struct inode *inode, sector_t block, struct buffer_head *bh, int create) { - if (block < 0) - goto abort_negative; - if (!create) { if (block >= inode->i_blocks) goto abort_toobig; @@ -34,10 +31,6 @@ adfs_get_block(struct inode *inode, sector_t block, struct buffer_head *bh, /* don't support allocation of blocks yet */ return -EIO; -abort_negative: - adfs_error(inode->i_sb, "block %d < 0", block); - return -EIO; - abort_toobig: return 0; }