All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sachin Sant <sachinp@in.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB
Date: Tue, 23 Jun 2009 08:56:23 +0530	[thread overview]
Message-ID: <4A404B5F.80903@in.ibm.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0906221927280.3240@localhost.localdomain>

Linus Torvalds wrote:
> On Tue, 23 Jun 2009, Benjamin Herrenschmidt wrote:
>
>   
>> +	/*
>> +	 * This initializes the mutex used by get/put_online_cpus()
>> +	 * which is used by SLAB
>> +	 */
>> +	cpu_hotplug_init();
>>     
>
> Oh fudge it.
>
> Why not get rid of that stupid thing, rather than have that subtle 
> dependency and a comment for it.
>
> IOW, does this simpler alternative also work?
This fixes the problem for me.

Thanks
-Sachin


-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------


  parent reply	other threads:[~2009-06-23  3:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-23  0:31 [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB Benjamin Herrenschmidt
2009-06-23  1:13 ` James Bottomley
2009-06-23  2:29 ` Linus Torvalds
2009-06-23  2:59   ` Benjamin Herrenschmidt
2009-06-23  3:23   ` Benjamin Herrenschmidt
2009-06-23  3:26   ` Sachin Sant [this message]
2009-06-23  4:00   ` James Bottomley
2009-06-23  5:59   ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A404B5F.80903@in.ibm.com \
    --to=sachinp@in.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.