From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c
Date: Tue, 23 Jun 2009 09:53:55 -0700 [thread overview]
Message-ID: <4A4108A3.8060003@am.sony.com> (raw)
In-Reply-To: <8977d21ed6cf59b89f9a830d59968ce178420a46.1245722192.git.michael@ellerman.id.au>
On 06/22/2009 06:56 PM, Michael Ellerman wrote:
> The non-debug case in ps3/mm.c uses pr_debug(), so that the compiler
> still does type checks etc. and doesn't complain about unused
> variables in the non-debug case.
>
> However with DEBUG=n and CONFIG_DYNAMIC_DEBUG=y there's still code
> generated for those pr_debugs().
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> ---
> arch/powerpc/platforms/ps3/mm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Looks good, thanks. I put it on the todo list to go through
the the remaining PS3 code to check for the same.
Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
next prev parent reply other threads:[~2009-06-23 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 1:56 [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c Michael Ellerman
2009-06-23 16:53 ` Geoff Levand [this message]
2009-06-24 0:55 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4108A3.8060003@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.