All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Brindle <method@manicmethod.com>
To: Chad Sellers <csellers@tresys.com>
Cc: Daniel J Walsh <dwalsh@redhat.com>, SE Linux <selinux@tycho.nsa.gov>
Subject: Re: SELinux context patch
Date: Tue, 23 Jun 2009 13:10:03 -0400	[thread overview]
Message-ID: <4A410C6B.4020406@manicmethod.com> (raw)
In-Reply-To: <C64DB16C.A7B20%csellers@tresys.com>

Chad Sellers wrote:
> On 5/18/09 2:16 PM, "Daniel J Walsh"<dwalsh@redhat.com>  wrote:
>
>> This patch adds context files for virtual_domain and virtual_image,
>> these are both being used to locat the default context to be executed by
>> svirt.
>>
>> I also included the subs patch which I submitted before.  This patch
>> allows us to substitute prefixes to matchpathcon.
>>
>> So we can say /export/home == /home
>>
>> and
>>
>> /web == /var/www
>
> The only problem I see with the patch is:
>
> +                       sub->dst=strdup(dst);
> +                       if (! sub->dst) {
> +                               free(sub);
> +                               free(sub->src);
> +                               return -1;
> +                       }
>
> the free()'s should be reversed in order. Other than that the patch looks
> fine. I'll fix this in the merge.
>
> Acked-by: Chad Sellers<csellers@tresys.com>
>

Merged in libselinux 2.0.82

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

      reply	other threads:[~2009-06-23 17:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 18:16 SELinux context patch Daniel J Walsh
2009-05-20 16:08 ` Chad Sellers
2009-06-04 19:13   ` Caleb Case
2009-06-04 20:47     ` Chad Sellers
2009-06-04 21:07       ` Daniel J Walsh
2009-06-04 21:15     ` Daniel J Walsh
2009-06-05 17:12     ` Christopher J. PeBenito
2009-06-05 17:24       ` Christopher J. PeBenito
2009-06-04 21:14 ` Chad Sellers
2009-06-23 17:10   ` Joshua Brindle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A410C6B.4020406@manicmethod.com \
    --to=method@manicmethod.com \
    --cc=csellers@tresys.com \
    --cc=dwalsh@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.