From: "Richard A. Smith" <richard@laptop.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Andres Salomon <dilinger@collabora.co.uk>,
cbou@mail.ru, dwmw2@infradead.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Paul Fox <pgf@laptop.org>,
dsaxena@laptop.org
Subject: Re: [PATCH 3/5] power_supply: add a TRICKLE_CHARGING status, and add it to the olpc driver
Date: Tue, 23 Jun 2009 19:13:17 -0400 [thread overview]
Message-ID: <4A41618D.4020900@laptop.org> (raw)
In-Reply-To: <20090623224434.GB16188@opensource.wolfsonmicro.com>
Mark Brown wrote:
> The problem here is that anything which is already looking at these
> statuses is going to have to be able to cope with the information too.
> In the OLPC case it probably doesn't matter so much if they get
> confused since this is an unusual case but in the embedded case it's
> much more normal (and more likely to happen while a user interacts with
> the device since that tends to burn power which is a problem if you're
> charging off USB).
> A separate file with the detailed information would sidestep this since
> it's a new interface. I'm not strongly opposed to adding the new states
> but I do think it's worth considering other ways of doing this.
I've got no problems with a new interface. But, i'm also not the person
writing the driver. :)
I can change my script to test for the presence of this new interface
and use that if it exists rather easily. I already have to handle a few
cases like that where Andres changed things when I wasn't watching.
Suggestions on what it would look like?
--
Richard Smith <richard@laptop.org>
One Laptop Per Child
next prev parent reply other threads:[~2009-06-23 23:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 3:46 [PATCH 3/5] power_supply: add a TRICKLE_CHARGING status, and add it to the olpc driver Andres Salomon
2009-06-23 10:37 ` Mark Brown
2009-06-23 19:28 ` Richard A. Smith
2009-06-23 22:44 ` Mark Brown
2009-06-23 23:13 ` Richard A. Smith [this message]
2009-06-23 23:25 ` Mark Brown
2009-06-23 23:46 ` Richard A. Smith
2009-06-24 10:09 ` Mark Brown
2009-06-30 6:20 ` Andres Salomon
2009-06-24 14:40 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A41618D.4020900@laptop.org \
--to=richard@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbou@mail.ru \
--cc=dilinger@collabora.co.uk \
--cc=dsaxena@laptop.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgf@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.