From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] FUSE: make request_wait_answer() wait for ->end() completion
Date: Wed, 24 Jun 2009 09:04:11 +0900 [thread overview]
Message-ID: <4A416D7B.4060804@kernel.org> (raw)
In-Reply-To: <20090623165354.073a61fe.akpm@linux-foundation.org>
(restoring cc list)
Andrew Morton wrote:
> On Thu, 18 Jun 2009 18:24:31 +0900
> Tejun Heo <tj@kernel.org> wrote:
>
>> - /** Request completion callback */
>> + /** Request completion callback. This function is called from
>> + the kernel context of the FUSE server if the request isn't
>> + being aborted. If the request is being aborted, it's
>> + called from the kernel context of the aborting process. */
>
> The comment pretends to be kerneldoc but isn't.
>
> Like this:
>
> /*
> * Request completion callback. This function is called from
> * the kernel context of the FUSE server if the request isn't
> * being aborted. If the request is being aborted, it's
> * called from the kernel context of the aborting process.
> */
>
> please.
All the sorrounding comments were formatted in false-kerneldoc format,
so it will look a bit weird that way. Hmm... I'll add a patch to
change the surrounding comments too.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-06-24 0:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 9:24 [PATCHSET] FUSE/CUSE: implement direct mmap, take#3 Tejun Heo
2009-06-18 9:24 ` [PATCH 1/4] fdtable: export alloc_fd() Tejun Heo
2009-06-24 4:39 ` Al Viro
2009-06-30 3:05 ` Tejun Heo
2009-06-18 9:24 ` [PATCH 2/4] FUSE: make request_wait_answer() wait for ->end() completion Tejun Heo
[not found] ` <20090623165354.073a61fe.akpm@linux-foundation.org>
2009-06-24 0:04 ` Tejun Heo [this message]
2009-06-24 10:02 ` Miklos Szeredi
2009-06-29 16:20 ` Tejun Heo
2009-06-18 9:24 ` [PATCH 3/4] FUSE: implement fuse_req->prep() Tejun Heo
2009-06-23 23:56 ` Andrew Morton
2009-06-24 0:07 ` Tejun Heo
2009-06-18 9:24 ` [PATCH 4/4] FUSE: implement direct mmap Tejun Heo
2009-06-24 0:14 ` Andrew Morton
2009-06-29 16:59 ` Tejun Heo
2009-06-24 10:33 ` Miklos Szeredi
2009-06-29 16:42 ` Tejun Heo
2009-07-02 13:51 ` Miklos Szeredi
2009-07-04 11:14 ` Tejun Heo
2009-07-06 11:41 ` Miklos Szeredi
2009-07-08 23:14 ` Tejun Heo
2009-07-09 10:35 ` Miklos Szeredi
2009-06-18 9:27 ` [PATCH libfuse] implement direct mmap support Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A416D7B.4060804@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.