All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seewer Philippe <philippe.seewer-omB+W0Dpw2o@public.gmane.org>
To: Warren Togami <wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "<initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>"
	<initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Old style <server-ip>:/<path> not handled
Date: Wed, 24 Jun 2009 08:51:26 +0200	[thread overview]
Message-ID: <4A41CCEE.9050705@bfh.ch> (raw)
In-Reply-To: <4A410FA7.8000509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>



Warren Togami wrote:
>> # This script is sourced, so root should be set. But let's be paranoid
>> [ -z "$root" ] && root=$(getarg root=)
>> [ -z "$netroot" ] && netroot=$(getarg netroot=)
>> [ -z "$nfsroot" ] && nfsroot=$(getarg nfsroot=)
>>
>> # Handle old style <server-ip>:/<path
>> case "$netroot" in
>>     [0-9]*:/*|[0-9]*\.[0-9]*\.[0-9]*[!:]|/*)
>>        netroot=nfs:$netroot;;
>> esac
> 
> By the current code it seems the old style root=<server-ip>:/<path> is 
> not actually handled.

The current code only handles netroot=<oldstyle>. This works for cmdline 
or if <oldstyle> is delivered by dhcp root-path. I think that was 
haralds intention anyway.

> I'm soon pushing a patch that restricts NFS to only root= which should 
> fix this and eliminate the redundant root= and netroot= test cases.
> 
> Warren Togami
> wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
> -- 
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2009-06-24  6:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-23 17:23 Old style <server-ip>:/<path> not handled Warren Togami
     [not found] ` <4A410FA7.8000509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-06-24  6:51   ` Seewer Philippe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A41CCEE.9050705@bfh.ch \
    --to=philippe.seewer-omb+w0dpw2o@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.