All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	David Miller <davem@davemloft.net>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM
Date: Wed, 24 Jun 2009 08:52:38 +0200	[thread overview]
Message-ID: <4A41CD36.8030202@hartkopp.net> (raw)
In-Reply-To: <4A412C53.8050607@grandegger.com>

Wolfgang Grandegger wrote:
> Heiko Carstens wrote:


>> Index: linux-2.6/drivers/net/can/Kconfig
>> ===================================================================
>> --- linux-2.6.orig/drivers/net/can/Kconfig
>> +++ linux-2.6/drivers/net/can/Kconfig
>> @@ -36,7 +36,7 @@ config CAN_CALC_BITTIMING
>>  	  If unsure, say Y.
>>  
>>  config CAN_SJA1000
>> -	depends on CAN_DEV
>> +	depends on CAN_DEV && HAS_IOMEM
>>  	tristate "Philips SJA1000"
>>  	---help---
>>  	  Driver for the SJA1000 CAN controllers from Philips or NXP
> 
> Hm, this Kconfig entry is not directly responsible for building
> sja1000_platform.o. It builds sja1000.o, which does not rely on
> HAS_IOMEM. It should be added to "config CAN_SJA1000_PLATFORM" instead.

Hi Wolfgang,

the question is, if we should add HAS_IOMEM to almost every SJA1000 depended
driver like SJA1000_PLATFORM, SJA1000_OF_PLATFORM, EMS_PCI and KVASER_PCI ???

Is it possible to have a support for the SJA1000 that does *not* depend on
HAS_IOMEM?

Regards,
Oliver

  reply	other threads:[~2009-06-24  6:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-23  7:31 [PATCH] can: let SJA1000 driver depend on HAS_IOMEM Heiko Carstens
2009-06-23 11:19 ` David Miller
2009-06-23 19:26 ` Wolfgang Grandegger
2009-06-24  6:52   ` Oliver Hartkopp [this message]
2009-06-24  7:01     ` David Miller
2009-06-24  8:26       ` Wolfgang Grandegger
2009-06-24  8:35         ` Oliver Hartkopp
2009-06-24  8:51           ` Wolfgang Grandegger
2009-06-24  9:07             ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A41CD36.8030202@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.