[Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Jes Sorensen <jes@sgi.com>]

On 06/23/2009 05:47 PM, Avi Kivity wrote:
> On 06/23/2009 06:07 PM, Jes Sorensen wrote:
>> DEF("smp", HAS_ARG, QEMU_OPTION_smp,
>> - "-smp n set the number of CPUs to 'n' [default=1]\n")
>> + "-smp n,[maxcpus=cpus]\n"
>
> -smp n[,maxcpus=cpus]

I don't follow you there, please elaborate.

>> + if (*p++ != ',')
>> + break;
>
> Won't this misparse "-smp 17z"?

It will be parsed as -smp 17, which is consistent with how the rest of
the options are parsed in QEMU. I am not going to rewrite the whole
parser for you :)

Cheers,
Jes