From: Jes Sorensen <jes@sgi.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [patch 1/2] Introduce -smp , maxcpus= flag to specify maximum number of CPUS.
Date: Wed, 24 Jun 2009 11:02:48 +0200 [thread overview]
Message-ID: <4A41EBB8.5000802@sgi.com> (raw)
In-Reply-To: <4A41EBBD.3090707@redhat.com>
On 06/24/2009 11:02 AM, Avi Kivity wrote:
> On 06/24/2009 11:35 AM, Jes Sorensen wrote:
>> Follow on patch will use it to determine the size of the MADT and
>> other BIOS tables.
>>
>> +int max_cpus = 16;
>
> Again I should have noticed this before, but this and the other
> constants should come from the QEMUMachine we're targeting, since each
> target has different limits.
Actually this is on purpose. The PC machine has a max limit of 255, if
we use that as the max per default, you are going to get a BIOS
declaring 255 possible CPUs and certain broken operating systems are not
going to boot.
So I will argue the code is correct as is.
Cheers,
Jes
next prev parent reply other threads:[~2009-06-24 9:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 8:35 [Qemu-devel] [patch 0/2] QEMU maxcpus support v2 Jes Sorensen
2009-06-24 8:35 ` [Qemu-devel] [patch 1/2] Introduce -smp , maxcpus= flag to specify maximum number of CPUS Jes Sorensen
2009-06-24 9:02 ` [Qemu-devel] " Avi Kivity
2009-06-24 9:02 ` Jes Sorensen [this message]
2009-06-24 9:15 ` Avi Kivity
2009-06-24 12:04 ` Jes Sorensen
2009-06-24 8:35 ` [Qemu-devel] [patch 2/2] QEMU BOCHS bios patches to use maxcpus value Jes Sorensen
2009-07-09 21:57 ` Anthony Liguori
2009-07-12 9:39 ` Avi Kivity
2009-07-12 13:23 ` Anthony Liguori
2009-07-12 13:36 ` Avi Kivity
2009-07-14 8:38 ` Jes Sorensen
2009-07-14 9:21 ` Filip Navara
2009-07-14 9:32 ` Gleb Natapov
2009-07-14 10:16 ` Alexander Graf
2009-07-14 11:15 ` Filip Navara
2009-07-14 11:21 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A41EBB8.5000802@sgi.com \
--to=jes@sgi.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.