From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting
Date: Wed, 24 Jun 2009 13:41:48 +0200 [thread overview]
Message-ID: <4A4210FC.6010102@gmail.com> (raw)
In-Reply-To: <20090623163006.f05b75ee.akpm@linux-foundation.org>
On 06/24/2009 01:30 AM, Andrew Morton wrote:
> On Thu, 18 Jun 2009 09:46:13 +0200
>> --- a/drivers/char/tty_port.c
>> +++ b/drivers/char/tty_port.c
>> @@ -193,7 +193,7 @@ int tty_port_block_til_ready(struct tty_port *port,
>> {
>> int do_clocal = 0, retval;
>> unsigned long flags;
>> - DECLARE_WAITQUEUE(wait, current);
>> + DEFINE_WAIT(wait);
>> int cd;
>>
>> /* block if port is in the process of being closed */
>
> Why is nobody reporting the oopses?
Myaybe because only few drivers use that function. I hit it the first
time I tested cyclades patchset.
prev parent reply other threads:[~2009-06-24 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 7:46 [PATCH v2 1/1] Char: tty, fix tty_port_block_til_ready waiting Jiri Slaby
2009-06-23 23:30 ` Andrew Morton
2009-06-24 11:41 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4210FC.6010102@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.