From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH 1/1] cr: uts: don't pass an unsigned var as a signed int Date: Wed, 24 Jun 2009 13:07:27 -0400 Message-ID: <4A425D4F.2010103@cs.columbia.edu> References: <20090619203719.GA30093@us.ibm.com> <20090621001837.GA32394@hallyn.com> <20090621191305.GA2499@hallyn.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Nathan Lynch Cc: Linux Containers List-Id: containers.vger.kernel.org Nathan Lynch wrote: [...] > "Serge E. Hallyn" writes: [...] >> Oren, >> >> would it be possible to put up a filter, either manual or >> automatic, to send every patch that gets pushed on the current >> ckpt git branch to the containers list, maybe with a [CKPT PUSH] >> tag in the subject line? > > Or just post patches to the mailing list before committing them to > public branches on which others are basing work. > > This seems like an opportune moment to point out the guidelines for > including a tree in linux-next: > > all patches/commits in the tree/series must have been: > > posted to a relevant mailing list > reviewed > unit tested > destined for the next merge window (or the current release) > > *before* they are included. > > (source: http://lkml.org/lkml/2009/6/20/6 ) > > If upstream inclusion is the ultimate goal, those are the standards > which apply. > > >> I think it will foster much more review of every patch. Right now >> it feels like we just catch blatant bugs when they bite us too hard, >> but I don't think many people are looking through 'git wc' every >> day. Yes, I agree with both suggestions, and will do both. FWIW, I decided to push less-tested code to avoid delay for a long period due to travel plans. Posting them on the list would have helped to improve them, of course. Oren.