From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, kevin.huang@rdc.com.tw,
greg@kroah.com,
Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] pata_rdc: driver for RDC ATA devices
Date: Wed, 24 Jun 2009 15:35:41 -0400 [thread overview]
Message-ID: <4A42800D.6020202@garzik.org> (raw)
In-Reply-To: <20090624172930.24354.80799.stgit@t61.ukuu.org.uk>
Alan Cox wrote:
> Try this version instead - forgot to refresh the patch before sending
>
> From: Alan Cox <alan@linux.intel.com>
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/ata/Kconfig | 10 +
> drivers/ata/Makefile | 1
> drivers/ata/pata_rdc.c | 400 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 411 insertions(+), 0 deletions(-)
> create mode 100644 drivers/ata/pata_rdc.c
Requesting that linux-ide be CC'd in the future, for this driver...
Seems fine and fairly straightforward to me. My lone comment -- go
through and replace magic numbers with named constants, for e.g. the PCI
config registers that program timings...
Jeff
next prev parent reply other threads:[~2009-06-24 19:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 17:29 [PATCH] pata_rdc: driver for RDC ATA devices Alan Cox
2009-06-24 19:35 ` Jeff Garzik [this message]
2009-06-24 22:55 ` Alan Cox
2009-06-24 23:33 ` Joe Perches
2009-06-24 23:38 ` Jeff Garzik
2009-06-25 4:27 ` Kevin Huang (黃凱文)
2009-06-25 4:27 ` Kevin Huang (黃凱文)
2009-07-29 1:16 ` Jeff Garzik
2009-07-29 2:53 ` Greg KH
2009-07-29 3:05 ` Jeff Garzik
2009-07-29 3:37 ` Stephen Rothwell
2009-07-29 13:56 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2009-06-24 17:10 Alan Cox
2009-06-24 16:38 ` Joe Perches
2009-06-24 16:42 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A42800D.6020202@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=kevin.huang@rdc.com.tw \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.