Re: [PATCH] libata: Delegate nonrot flag setting to SCSI

[Jeff Garzik <jeff@garzik.org>]

Martin K. Petersen wrote:
> Now that the SCSI disk driver correctly handles non-rotational devices
> we can move setting the queue flag to SCSI.
> 
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> 
> ---
> 
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1119,10 +1119,6 @@ static int ata_scsi_dev_config(struct sc
>  
>  		blk_queue_dma_drain(q, atapi_drain_needed, buf, ATAPI_MAX_DRAIN);
>  	} else {
> -		if (ata_id_is_ssd(dev->id))
> -			queue_flag_set_unlocked(QUEUE_FLAG_NONROT,
> -						sdev->request_queue);
> -

Does the existence of this code cause any problems or regressions today?

It looks correct vis a vis current drivers/scsi/sd.c, but given that the 
merge window just closed, I lean towards classifying this as a cleanup 
(thus, 2.6.32).

	Jeff