All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: drive_add vs. pci_add
Date: Thu, 25 Jun 2009 09:15:57 +0200	[thread overview]
Message-ID: <4A43242D.9090106@web.de> (raw)
In-Reply-To: <4A431D3D.2040604@web.de>

Jan Kiszka wrote:
> Hi,
> 
> sorry, it's still early, but isn't the monitor command 'drive_add'
> completely redundant to 'pci_add ... storage'? If yes, and drive_add is
> only there for legacy users, I would mask its help from the monitor
> interface to avoid confusion.

One coffee later, the picture is clear: drive_add adds a drive to an
existing controller (one should read the doc completely). 'pci_add ...
storage' adds a storage controller, but can also add a first drive to
that controller. The latter feature definitely requires a better
documentation than "Hot-add PCI device".

Jan

  reply	other threads:[~2009-06-25  7:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25  6:46 [Qemu-devel] drive_add vs. pci_add Jan Kiszka
2009-06-25  7:15 ` Jan Kiszka [this message]
2009-06-25 15:39 ` Avi Kivity
2009-06-25 16:02   ` Paul Brook
2009-06-25 18:28     ` Anthony Liguori
2009-06-25 21:09       ` Jan Kiszka
2009-06-25 22:18       ` Paul Brook
2009-06-25 16:07   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A43242D.9090106@web.de \
    --to=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.