From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: A typo in vram dirty tracking function?
Date: Thu, 25 Jun 2009 13:26:49 +0100
Message-ID: <4A436D09.6010702@eu.citrix.com>
References: <4A42B05E.8060108@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4A42B05E.8060108@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Wei Huang <wei.huang2@amd.com>
Cc: "'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Wei Huang wrote:

> Is this a typo? I haven't tried it myself. But did you want to convert 
> logdirty to rw mode?
> 
> -Wei
> 
> --- a/xen/arch/x86/mm/hap/hap.c Sun Jun 28 22:17:37 2009 -0500
> +++ b/xen/arch/x86/mm/hap/hap.c Mon Jun 29 07:43:11 2009 -0500
> @@ -90,7 +90,7 @@ int hap_disable_vram_tracking(struct dom
> 
>       /* set l1e entries of P2M table with normal mode */
>       for (i = dirty_vram->begin_pfn; i < dirty_vram->end_pfn; i++)
> -        p2m_change_type(d, i, p2m_ram_rw, p2m_ram_logdirty);
> +        p2m_change_type(d, i, p2m_ram_logdirty, p2m_ram_rw);
> 
>       flush_tlb_mask(&d->domain_dirty_cpumask);
> 
> 


Yes, this is a typo. Thanks for pointing it out!