From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcov: fix __ctors_start alignment
Date: Thu, 25 Jun 2009 15:56:05 +0200 [thread overview]
Message-ID: <4A4381F5.5010405@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090625101147.GB5051@osiris.boeblingen.de.ibm.com>
Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> The ctors section for each object file is eight byte aligned (on 64 bit).
> However the __ctors_start symbol starts at an arbitrary address dependent
> on the size of the previous sections.
> Therefore the linker may add some zeroes after __ctors_start to make sure
> the ctors contents are properly aligned. However the extra zeroes at the
> beginning aren't expected by the code. When walking the functions pointers
> contained in there and extra zeroes are added this may result in random
> jumps.
> So make sure that the __ctors_start symbol is always aligned as well.
Ack. And good find! :) Also with this patch applied, the x86_64 boot
problem reported by Ingo Molnar no longer occurs.
prev parent reply other threads:[~2009-06-25 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 10:11 [PATCH] gcov: fix __ctors_start alignment Heiko Carstens
2009-06-25 13:56 ` Peter Oberparleiter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4381F5.5010405@linux.vnet.ibm.com \
--to=oberpar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.