Avi Kivity wrote: > On 06/25/2009 09:46 AM, Jan Kiszka wrote: >> Hi, >> >> sorry, it's still early, but isn't the monitor command 'drive_add' >> completely redundant to 'pci_add ... storage'? If yes, and drive_add is >> only there for legacy users, I would mask its help from the monitor >> interface to avoid confusion. >> > > What we really want is pci_add storage to add a storage controller, and > drive_add to attach a drive to that controller. I don't think that's > what happens now. > The latter should already happen, but we probably need to drop that "first drive included" from the former. Also, there is no drive_remove. I'm going to did into the whole hotplug user interface later, it has some room for improvements. Jan