From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: maximilian attems <max@stro.at>,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
ink@jurassic.park.msu.ru
Subject: Re: >= 2.6.30 broken alpha smp build
Date: Fri, 26 Jun 2009 09:43:22 +0900 [thread overview]
Message-ID: <4A4419AA.2040400@kernel.org> (raw)
In-Reply-To: <20090625115423.6a31b49c.akpm@linux-foundation.org>
Andrew Morton wrote:
> This is the
>
> #define PER_CPU_ATTRIBUTES __used
>
> in arch/alpha/include/asm/percpu.h, added by
>
> commit 9267b4b3880d00dc2dab90f1d817c856939114f7
> Author: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> AuthorDate: Sat Jun 21 03:25:39 2008 +0400
> Commit: Linus Torvalds <torvalds@linux-foundation.org>
> CommitDate: Fri Jun 20 16:46:10 2008 -0700
>
> alpha: fix module load failures on smp (bug #10926)
>
> There's no indication in the changelog why this was added and afacit no
> other architectures do it. So I'm at a loss to help here.
The __used attribute is dropped by a patch in percpu patchset as it
caused build warning on my test builds and wasn't even effective
as-was (overriden by later NULL definition). Ivan, any ideas why it's
there?
Thanks.
--
tejun
next prev parent reply other threads:[~2009-06-26 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 9:08 >= 2.6.30 broken alpha smp build maximilian attems
2009-06-25 18:54 ` Andrew Morton
2009-06-26 0:43 ` Tejun Heo [this message]
2009-06-26 12:47 ` Ivan Kokshaysky
2009-06-26 18:57 ` Andrew Morton
2009-06-26 19:21 ` Andrew Morton
2009-06-28 0:49 ` [PATCH] alpha: fix percpu build breakage Tejun Heo
2009-06-28 11:39 ` Ivan Kokshaysky
2009-06-28 12:21 ` Tejun Heo
2009-06-28 15:50 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4419AA.2040400@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.