[lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Andre Prendel]

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues
according to your review. Please take a closer look at the
is_visible() callback of the sysfs group. I'm using the attributes' index
to decide whether the file is visible or not.

Jean, I know you're on vacation, so take your time :)

BTW I spend some time with my girlfriend at the Cote d'Azur last
year. Probably the best vacation I've ever had. But speaking french is
very difficult :)

Thanks,
Andre

---
 Documentation/hwmon/tmp421 |   36 ++++
 drivers/hwmon/Kconfig      |   10 +
 drivers/hwmon/Makefile     |    1 
 drivers/hwmon/tmp421.c     |  349 +++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 396 insertions(+)

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Hans de Goede]

Hi,

On 06/26/2009 10:10 AM, Andre Prendel wrote:
> Hello Jean, Hans,
>
> Here is an updated version of the tmp421 driver. I've fixed the issues
> according to your review. Please take a closer look at the
> is_visible() callback of the sysfs group. I'm using the attributes' index
> to decide whether the file is visible or not.
>

looks good to me,

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Jean Delvare]

On Fri, 26 Jun 2009 10:10:31 +0200, Andre Prendel wrote:
> Hello Jean, Hans,
> 
> Here is an updated version of the tmp421 driver. I've fixed the issues
> according to your review. Please take a closer look at the
> is_visible() callback of the sysfs group. I'm using the attributes' index
> to decide whether the file is visible or not.
> 
> Jean, I know you're on vacation, so take your time :)

Now that the wiki is back, please update the TMP421 etc. entry.

> BTW I spend some time with my girlfriend at the Cote d'Azur last
> year. Probably the best vacation I've ever had. But speaking french is
> very difficult :)

Yes French is indeed very difficult :( but we have beautiful landscapes
and excellent cuisine :)

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Andre Prendel]

On Sun, Jun 28, 2009 at 02:25:51PM +0200, Jean Delvare wrote:
> On Fri, 26 Jun 2009 10:10:31 +0200, Andre Prendel wrote:
> > Hello Jean, Hans,
> > 
> > Here is an updated version of the tmp421 driver. I've fixed the issues
> > according to your review. Please take a closer look at the
> > is_visible() callback of the sysfs group. I'm using the attributes' index
> > to decide whether the file is visible or not.
> > 
> > Jean, I know you're on vacation, so take your time :)
> 
> Now that the wiki is back, please update the TMP421 etc. entry.

Is the driver scheduled for 2.6.32 or the next rc?

> > BTW I spend some time with my girlfriend at the Cote d'Azur last
> > year. Probably the best vacation I've ever had. But speaking french is
> > very difficult :)
> 
> Yes French is indeed very difficult :( but we have beautiful landscapes
> and excellent cuisine :)

You're right :)

Thanks,
Andre

> -- 
> Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Jean Delvare]

On Mon, 29 Jun 2009 10:54:10 +0200, Andre Prendel wrote:
> On Sun, Jun 28, 2009 at 02:25:51PM +0200, Jean Delvare wrote:
> > On Fri, 26 Jun 2009 10:10:31 +0200, Andre Prendel wrote:
> > > Hello Jean, Hans,
> > > 
> > > Here is an updated version of the tmp421 driver. I've fixed the issues
> > > according to your review. Please take a closer look at the
> > > is_visible() callback of the sysfs group. I'm using the attributes' index
> > > to decide whether the file is visible or not.
> > > 
> > > Jean, I know you're on vacation, so take your time :)
> > 
> > Now that the wiki is back, please update the TMP421 etc. entry.
> 
> Is the driver scheduled for 2.6.32 or the next rc?

2.6.32.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Andre Prendel]

On Mon, Jun 29, 2009 at 06:48:29PM +0200, Jean Delvare wrote:
> On Mon, 29 Jun 2009 10:54:10 +0200, Andre Prendel wrote:
> > On Sun, Jun 28, 2009 at 02:25:51PM +0200, Jean Delvare wrote:
> > > On Fri, 26 Jun 2009 10:10:31 +0200, Andre Prendel wrote:
> > > > Hello Jean, Hans,
> > > > 
> > > > Here is an updated version of the tmp421 driver. I've fixed the issues
> > > > according to your review. Please take a closer look at the
> > > > is_visible() callback of the sysfs group. I'm using the attributes' index
> > > > to decide whether the file is visible or not.
> > > > 
> > > > Jean, I know you're on vacation, so take your time :)
> > > 
> > > Now that the wiki is back, please update the TMP421 etc. entry.

Done.

> > Is the driver scheduled for 2.6.32 or the next rc?
> 
> 2.6.32.

Thanks,
Andre

> -- 
> Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Jean Delvare]

On Tue, 30 Jun 2009 10:12:20 +0200, Andre Prendel wrote:
> On Mon, Jun 29, 2009 at 06:48:29PM +0200, Jean Delvare wrote:
> > On Mon, 29 Jun 2009 10:54:10 +0200, Andre Prendel wrote:
> > > On Sun, Jun 28, 2009 at 02:25:51PM +0200, Jean Delvare wrote:
> > > > On Fri, 26 Jun 2009 10:10:31 +0200, Andre Prendel wrote:
> > > > > Hello Jean, Hans,
> > > > > 
> > > > > Here is an updated version of the tmp421 driver. I've fixed the issues
> > > > > according to your review. Please take a closer look at the
> > > > > is_visible() callback of the sysfs group. I'm using the attributes' index
> > > > > to decide whether the file is visible or not.
> > > > > 
> > > > > Jean, I know you're on vacation, so take your time :)
> > > > 
> > > > Now that the wiki is back, please update the TMP421 etc. entry.
> 
> Done.

Thanks. Care to add support to sensors-detect too?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2 0/2] hwmon: Add support for TI's

[Andre Prendel]

On Tue, Jun 30, 2009 at 10:17:40AM +0200, Jean Delvare wrote:
> On Tue, 30 Jun 2009 10:12:20 +0200, Andre Prendel wrote:
> > On Mon, Jun 29, 2009 at 06:48:29PM +0200, Jean Delvare wrote:
> > > On Mon, 29 Jun 2009 10:54:10 +0200, Andre Prendel wrote:
> > > > On Sun, Jun 28, 2009 at 02:25:51PM +0200, Jean Delvare wrote:
> > > > > On Fri, 26 Jun 2009 10:10:31 +0200, Andre Prendel wrote:
> > > > > > Hello Jean, Hans,
> > > > > > 
> > > > > > Here is an updated version of the tmp421 driver. I've fixed the issues
> > > > > > according to your review. Please take a closer look at the
> > > > > > is_visible() callback of the sysfs group. I'm using the attributes' index
> > > > > > to decide whether the file is visible or not.
> > > > > > 
> > > > > > Jean, I know you're on vacation, so take your time :)
> > > > > 
> > > > > Now that the wiki is back, please update the TMP421 etc. entry.
> > 
> > Done.
> 
> Thanks. Care to add support to sensors-detect too?

I will have a look at it. But as I said, no time at the moment. I will
move 550km back to my hometown for a new job.

> -- 
> Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors