All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Add kvm_set_boot_cpu_id() API.
Date: Sun, 28 Jun 2009 12:29:26 +0300	[thread overview]
Message-ID: <4A4737F6.3050607@redhat.com> (raw)
In-Reply-To: <1245932460-15616-3-git-send-email-gleb@redhat.com>

On 06/25/2009 03:21 PM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
>    

Why is it needed? (good changelog material).

>       }
> -
> +
> +    kvm_set_boot_cpu_id(0);
>    

You're not testing for failure.  Doesn't matter here because it's the 
default, but then you can omit the call entirely.


-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-06-28  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25 12:21 [PATCH] Add kvm_set_boot_cpu_id() API Gleb Natapov
2009-06-28  9:29 ` Avi Kivity [this message]
2009-06-28  9:33   ` Gleb Natapov
2009-06-28 10:31     ` Avi Kivity
2009-06-28 12:25       ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4737F6.3050607@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.