All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miao Xie <miaox@cn.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Paul Menage <menage@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: remove obsoleted alloc_pages cpuset comment
Date: Sun, 28 Jun 2009 23:52:39 +0900	[thread overview]
Message-ID: <4A4783B7.8090706@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0906251346540.6083@chino.kir.corp.google.com>

> When a cpuset's nodemask is updated, all attached tasks have their cached
> task->mems_allowed updated by a heap instead of requiring an explicit
> call to cpuset_update_task_memory_state(), which has since been removed
> in 58568d2a8215cb6f55caf2332017d7bdff954e1c.
> 
> Remove the obsoleted comment from the page allocator.

Sorry. It's my mistake. Thanks for your fix.

Acked-by: Miao Xie <miaox@cn.fujitsu.com>

> 
> Cc: Paul Menage <menage@google.com>
> Cc: Miao Xie <miaox@cn.fujitsu.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  mm/page_alloc.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 5d714f8..8670fb7 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1620,10 +1620,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order,
>  
>  	/* We now go into synchronous reclaim */
>  	cpuset_memory_pressure_bump();
> -
> -	/*
> -	 * The task's cpuset might have expanded its set of allowable nodes
> -	 */
>  	p->flags |= PF_MEMALLOC;
>  	lockdep_set_current_reclaim_state(gfp_mask);
>  	reclaim_state.reclaimed_slab = 0;
> 
> 
> 



      reply	other threads:[~2009-06-28 14:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25 20:48 [patch] mm: remove obsoleted alloc_pages cpuset comment David Rientjes
2009-06-28 14:52 ` Miao Xie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4783B7.8090706@cn.fujitsu.com \
    --to=miaox@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.