From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gregory Haskins <ghaskins@novell.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
mtosatti@redhat.com, paulmck@linux.vnet.ibm.com,
markmc@redhat.com
Subject: Re: [PATCHv2] kvm: remove in_range and switch to rwsem for iobus
Date: Mon, 29 Jun 2009 12:57:22 +0300 [thread overview]
Message-ID: <4A489002.1080106@redhat.com> (raw)
In-Reply-To: <20090629095132.GD19167@redhat.com>
On 06/29/2009 12:51 PM, Michael S. Tsirkin wrote:
>> We can convert it to rcu indepenently of other things protected by
>> slots_lock; no need to do everything at the same time.
>>
>
> Yes but once we merge locks, it will be harder to split them out.
> I know I can now do grep bus_lock and find all places affected,
> if I reuse slot_lock this information is lost. No?
>
That's true, but for seeing the overall picture, fewer locks are
better. I'm more concerned about those looking at all the code (me)
than those implementing locking improvements (you).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-06-29 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 19:34 [PATCHv2] kvm: remove in_range and switch to rwsem for iobus Michael S. Tsirkin
2009-06-29 8:37 ` Avi Kivity
2009-06-29 9:23 ` Michael S. Tsirkin
2009-06-29 9:44 ` Avi Kivity
2009-06-29 9:51 ` Michael S. Tsirkin
2009-06-29 9:57 ` Avi Kivity [this message]
2009-06-29 9:41 ` Michael S. Tsirkin
2009-06-29 9:53 ` Avi Kivity
2009-06-29 10:06 ` Michael S. Tsirkin
2009-06-29 10:21 ` Avi Kivity
2009-06-29 14:06 ` Marcelo Tosatti
2009-06-29 14:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A489002.1080106@redhat.com \
--to=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.