From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
Philip Craig <philipc@snapgear.com>
Subject: Re: conntrack untracked match is broken (kernel patch)
Date: Mon, 29 Jun 2009 14:34:10 +0200 [thread overview]
Message-ID: <4A48B4C2.7080106@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0906251841140.23831@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Monday 2009-06-22 08:31, Philip Craig wrote:
>> The problem is that state_mask in 'struct xt_conntrack_mtinfo1' is
>> only 8 bit, but XT_CONNTRACK_STATE_UNTRACKED == 256.
>> Unfortunately, gcc doesn't warn about this for '|=', only for '='.
>
> I smell a gcc-missing-feature there.
>
>> Looks like we need a conntrack match v2 to fix this?
Sigh.
> Here is the kernel patch, please apply. Userspace as a reply.
>
> -----8<-----
> parent deb9f8e170eff8fd0476536bac3bf9bdc222d4ed (v2.6.30-5372-gdeb9f8e)
> commit 366d5a252fd0de33d7b3ef669551a8771748c9e3
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date: Thu Jun 25 18:35:39 2009 +0200
>
> netfilter: xtables: conntrack revision 2
>
> As reported by Philip, the UNTRACKED state bit does not fit within
> the 8-bit state_mask member. Enlarge state_mask and give status_mask
> a few more bits too.
Applied.
prev parent reply other threads:[~2009-06-29 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 6:31 conntrack untracked match is broken Philip Craig
2009-06-25 16:46 ` conntrack untracked match is broken (kernel patch) Jan Engelhardt
2009-06-25 16:48 ` conntrack untracked match is broken (userspace patch) Jan Engelhardt
2009-06-26 7:45 ` conntrack untracked match is broken (kernel patch) Philip Craig
2009-06-29 12:34 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A48B4C2.7080106@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=philipc@snapgear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.