Re: [Qemu-devel] [RESEND][PATCH] KVM: x86: Refactor persistent CPU state

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Anthony Liguori wrote:
> Blue Swirl wrote:
>> On 6/27/09, Jan Kiszka <jan.kiszka@web.de> wrote:
>>  
>>> This patch aligns the KVM-related layout and encoding of the CPU state
>>>  to be saved to disk or migrated with qemu-kvm. The major differences
>>> are
>>>  reordering of fields and a compressed interrupt_bitmap into a single
>>>  number as there can be no more than one pending IRQ at a time.
>>>     
>>
>> This changes the savevm format, shouldn't you bump the version?
>>   
> 
> Practically speaking, it's been bumped for KVM already in this release
> cycle so changing the format without bumping the version should be
> okay.  It may interfere with kvm-XX releases but I'm not sure whether
> that's an issue for us and how we should handle that long term.

That particular patch is already part of kvm-87. Here we are just
aligning both code bases, and that even on the same format version number.

> 
> I'm assuming Jan thought all of this through ahead of time and just
> forgot to explicitly state the reasoning for not bumping the version :-)

Of course, I considered every possible case in every detail. :)

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]