From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Gwendal Grignou <gwendal@google.com>,
jens.axboe@oracle.com, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] Allow ATA_ passthrough command through sg.
Date: Mon, 29 Jun 2009 19:26:44 -0400 [thread overview]
Message-ID: <4A494DB4.2060908@garzik.org> (raw)
In-Reply-To: <20090629232045.14a426b6@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Mon, 29 Jun 2009 14:24:25 -0700
> Gwendal Grignou <gwendal@google.com> wrote:
>
>> We can already send ATA specific commands using /dev/sd device files.
>> This patch allow to use /dev/sg device files as well.
>
> That seems a very very bad idea. The point of the filters is only to
> allow through commands that are safe for all users with read or write
> permission to use.
>
> Backdooring it with arbitary passthrough ATA12/ATA16 commands doesn't
> seem very wise.
Indeed. This pretty much defeats the filter for all ATA commands,
including ones that can brick your drive.
Jeff
next prev parent reply other threads:[~2009-06-29 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 21:24 [PATCH] Allow ATA_ passthrough command through sg Gwendal Grignou
2009-06-29 22:20 ` Alan Cox
2009-06-29 23:26 ` Jeff Garzik [this message]
2009-06-29 23:39 ` Gwendal Grignou
2009-06-30 0:21 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A494DB4.2060908@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gwendal@google.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.