All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] errno.h header -> asm-generic?
Date: Tue, 30 Jun 2009 15:55:08 +0200	[thread overview]
Message-ID: <4A4A193C.3040508@monstr.eu> (raw)
In-Reply-To: <20090630123356.GH23292@game.jcrosoft.org>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:55 Tue 30 Jun     , Stefan Roese wrote:
>> Hi Michal,
>>
>> On Tuesday 30 June 2009 12:00:55 Michal Simek wrote:
>>> I found that Microblaze miss errno.h file among some other minor fault
>>> which I want to fix.
>>>
>>> Anyway I looked at errno.h header file for all arch which are in U-BOOT and
>>> I found that almost all arch use the same file that's why I think that will
>>> be good to create (maybe asm-generic) folder with these type of generic
>>> file.
>>>
>>> What do you think guys?
>> Yes, I would welcome such a errno.h consolidation.
> ditto
> 

I have just sent patch to mailing list.

Some my comments:

MIPS has incompatible errno.h that's why I don't remove it - it is up to custodian.

NIOS, NIOS2, i386 don't have errno.h is asm folder -> this mean for me that they don't
need it. If yes, let me know.

Some archs define EDEADLOCK to 58 and some as EDEADLK. I looked at Linux kernel
and there is EDEADLK that's why I added this implementation is asm-generic.
#define	EDEADLOCK	58	/* File locking deadlock error */
#define	EDEADLOCK	EDEADLK

Some arch defined these 5 macros below - they are not used in U-BOOT that's why I removed them.

/* Should never be seen by user programs */
#define ERESTARTSYS	512
#define ERESTARTNOINTR	513
#define ERESTARTNOHAND	514	/* restart if no handler.. */
#define ENOIOCTLCMD	515	/* No ioctl command */

#define _LAST_ERRNO	515


Please test this change carefully. If you have any problem let me know.

Thanks,
Michal


> Best Regards,
> J.


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854

      reply	other threads:[~2009-06-30 13:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 10:00 [U-Boot] errno.h header -> asm-generic? Michal Simek
2009-06-30 11:55 ` Stefan Roese
2009-06-30 12:33   ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 13:55     ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4A193C.3040508@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.