All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Gleb Natapov <gleb@redhat.com>,
	Yinghai Lu <yhlu.kernel@gmail.com>,
	linux-kernel@vger.kernel.org,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	Sheng Yang <sheng@linux.intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v4] enable x2APIC without interrupt remapping under KVM
Date: Tue, 30 Jun 2009 20:14:58 +0300	[thread overview]
Message-ID: <4A4A4812.4070804@redhat.com> (raw)
In-Reply-To: <m11vp18xmp.fsf@fess.ebiederm.org>

On 06/30/2009 08:00 PM, Eric W. Biederman wrote:
> Gleb Natapov<gleb@redhat.com>  writes:
>
>    
>> On Tue, Jun 30, 2009 at 12:18:19AM -0700, Yinghai Lu wrote:
>>      
>>> how about kexec second kernel in KVM ?
>>>
>>> x2apic_preenabled will be set in second kernel.
>>>
>>>        
>> By the way anybody knows why kexec does not use BIOS reset code
>> (cmos 0xf offset) to jump into new kernel after hard reset?
>>      
>
> After a hard reset.  That simply isn't possible. A hard
> reset clears everything even memory.
>
>    

So the jump-to-vector reset code cannot work on real hardware?  It works 
in qemu, but of course that's easy.

> You might be able to get a full cpu reset but not a reset of the I/O
> devices.
>
> The premise of kexec is that we are doing things on our own, and don't
> get a 3rd piece of software involved that has not been heavily tested
> on the path we want to use.  Occassionally it is a pain to do everything
> ourselves but at least when we do and we test it we know it is going
> to work.
>
> Cpu designers lately seem fond of adding features that require all
> kind of coordination to turn on and off.  We handle the hardware
> virtualization mode features now, and if x2apic has similar problems
> being turned on and off I am certain we can handle that case in a
> similar fashion.
>
> When we can my preference is to keep code like that out of the
> kexec on panic path if we can figure out how to write the software
> to do something reasonable.
>
> Once we figure out how to work without putting the interrupt controllers
> in legacy mode to handle the timer interrupts I expect all kinds of
> things will become simpler.
>    

I think it makes sense to add full reset support as a non-default 
option.  Leaving hardware running and dmaing left and right has its risks.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2009-06-30 17:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30  6:45 [PATCH v4] enable x2APIC without interrupt remapping under KVM Gleb Natapov
2009-06-30  7:18 ` Yinghai Lu
2009-06-30  7:54   ` Gleb Natapov
2009-06-30 18:43     ` Yinghai Lu
2009-06-30 18:53       ` Gleb Natapov
2009-06-30 15:58   ` Gleb Natapov
2009-06-30 17:00     ` Eric W. Biederman
2009-06-30 17:14       ` Avi Kivity [this message]
2009-06-30 19:24         ` Eric W. Biederman
2009-06-30 19:15       ` Gleb Natapov
2009-06-30 17:15     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4A4812.4070804@redhat.com \
    --to=avi@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sheng@linux.intel.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.