From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey T Subject: Experience with netchannel2 Date: Mon, 29 Jun 2009 15:39:59 +0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1148902466==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com, Steven Smith List-Id: xen-devel@lists.xenproject.org --===============1148902466== Content-Type: multipart/alternative; boundary=00163662e5c66cb923046d7b2640 --00163662e5c66cb923046d7b2640 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hello, Steven! I'd like to ask you some questions about netchannel2. All I've done were with http://xenbits.xensource.com/ext/netchannel2/xen-unstable.hg http://xenbits.xensource.com/ext/netchannel2/linux-2.6.18.hg 1. During xen-netchannel2 building, vif2 script tools/hotplug/Linux/vif2 isn't installed to /etc/xen/scripts. Is this script needed at all? What variable should be placed in domU config : 'vif' or 'vif2'? 2. I have managed to start domU with netchannel2 succesfully with single virtual ethernet card. But when I added second vif device to the domU configuration, i got black screen in dom0, during domU starting. It happens on the on network initialisation stage, so i could consider netchannel2 affects this somehow. I didn't dig it yet, but it's critical to me to have more then one NIC. Thank you in advance. Sergey. --00163662e5c66cb923046d7b2640 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello, Steven!

I'd like to ask you some questions about netchann= el2.
All I've done were with
http://xenbits.xensource.com/ext/netch= annel2/xen-unstable.hg
ht= tp://xenbits.xensource.com/ext/netchannel2/linux-2.6.18.hg

1. Du= ring xen-netchannel2 building, vif2 script
tools/hotplug/Linux/vif2 isn= 't installed to /etc/xen/scripts.
Is this script needed at all?
What variable should be placed in domU con= fig : 'vif' or 'vif2'?

2. I have managed to start do= mU with netchannel2 succesfully with single virtual ethernet card.
=A0Bu= t when I added second vif device to the domU configuration, i got black scr= een in dom0, during
domU starting. It happens on the on network initialisation stage, so i coul= d consider netchannel2
affects this somehow. I didn't dig it yet, b= ut it's critical to me to have more then one NIC.

Thank you in a= dvance.

Sergey.
--00163662e5c66cb923046d7b2640-- --===============1148902466== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1148902466==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Smith Subject: Re: Experience with netchannel2 Date: Tue, 30 Jun 2009 12:53:31 +0100 Message-ID: <20090630115331.GA8688@weybridge.uk.xensource.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0560883080==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Sergey T Cc: Smith , "xen-devel@lists.xensource.com" Steven List-Id: xen-devel@lists.xenproject.org --===============0560883080== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Hello, Steven! >=20 > I'd like to ask you some questions about netchannel2. > All I've done were with > http://xenbits.xensource.com/ext/netchannel2/xen-unstable.hg > http://xenbits.xensource.com/ext/netchannel2/linux-2.6.18.hg >=20 > 1. During xen-netchannel2 building, vif2 script > tools/hotplug/Linux/vif2 isn't installed to /etc/xen/scripts. > Is this script needed at all? It is needed, and it should be installed in /etc/xen/scripts. The normal tools makefiles are supposed to do this automatically when you run ``make install'' (and they do on my test box). Could you post the output of ``cd tools/hotplug; make install'', please? > What variable should be placed in domU config : 'vif' or 'vif2'? vif2. e.g.: vif2 =3D [ 'bridge=3Deth1' ] > 2. I have managed to start domU with netchannel2 succesfully with single = virtual ethernet card. > But when I added second vif device to the domU configuration, i got blac= k screen in dom0, during > domU starting. It happens on the on network initialisation stage, so i co= uld consider netchannel2 > affects this somehow. I didn't dig it yet, but it's critical to me to hav= e more then one NIC. What do you mean by ``black screen''? That dom0 crashes? Is there any chance you could get a serial console on it, please? Steven. --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFKSfy7vAgSWYI3DVMRAiRxAKCOBqh5cgzyoQvBjqfcDrIwdj5U7gCeMFTD /iZ0cqM1i0yueMRRVB4ORRM= =ixdj -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK-- --===============0560883080== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0560883080==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Tovpeko Subject: Re: Experience with netchannel2 Date: Wed, 01 Jul 2009 14:02:32 +0400 Message-ID: <4A4B3438.10206@gmail.com> References: <20090630115331.GA8688@weybridge.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060606080402050300030001" Return-path: In-Reply-To: <20090630115331.GA8688@weybridge.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Steven Smith Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------060606080402050300030001 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Steven. >> 1. During xen-netchannel2 building, vif2 script >> tools/hotplug/Linux/vif2 isn't installed to /etc/xen/scripts. >> Is this script needed at all? >> > It is needed, and it should be installed in /etc/xen/scripts. The > normal tools makefiles are supposed to do this automatically when you > run ``make install'' (and they do on my test box). Could you post > the output of ``cd tools/hotplug; make install'', please? > I've attached the log in 'hotplug_makefile' file. It seems that tools/hotplug/Makefile doesn't know that it should place 'vif2' to /etc/xen/scripts. >> What variable should be placed in domU config : 'vif' or 'vif2'? >> > vif2. e.g.: > > vif2 = [ 'bridge=eth1' ] > Hmm, there is no key 'bridge' for vif2 in tools/python/xen/xm/create.py And domU doesn't start with Error: Invalid vif option: bridge for c in vifs2: d = comma_sep_kv_to_dict(c) config_vif = ['vif2'] for k in d.keys(): if k not in ['front_mac', 'back_mac', 'backend', 'pdev', 'max_bypasses']: err('Invalid vif option: ' + k) config_vif.append([k, d[k]]) config_devs.append(['device', config_vif]) Moreover, the domU is starting without 'bridge' key with vif2 =[ '' ] but what i have, are 1. Virtual network interface is created in dom0 with name 'eth1', while in old netchannel1, virtual network intarface has the name 'vifN.M'. It's very strange that i have 'eth1' instead of 'vifN.M'. 2. Despite the fact that DomU have started, there no connection in domU. I suppose it's due to the virtual interface have not been attached to the bridge in Dom0. I noticed that there are differencies between /etc/xen/scripts/vif and /etc/xen/scritps/vif2. The old vif uses 'brctl show' command to find the bridge, but vif2 script doesn't. >> 2. I have managed to start domU with netchannel2 succesfully with single virtual ethernet card. >> But when I added second vif device to the domU configuration, i got black screen in dom0, during >> domU starting. It happens on the on network initialisation stage, so i could consider netchannel2 >> affects this somehow. I didn't dig it yet, but it's critical to me to have more then one NIC. >> > What do you mean by ``black screen''? That dom0 crashes? Is there > any chance you could get a serial console on it, please? > I mean my dom0 is rebooting, tripple fault have been occured. I'm going to research this problem. Here my test case 1. Start domU with two netchannel1 NIC vif = [ '', '' ] 2. In DomU obtain IP-address manually for first NIC, then for second one. dhclient eth0 dhclient eth1 Before second dhclient finished, dom0 goes to reboot. Best regards, Sergey Tovpeko. --------------060606080402050300030001 Content-Type: text/plain; name="hotplug_makefile" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="hotplug_makefile" bWFrZVsxXTogRW50ZXJpbmcgZGlyZWN0b3J5IGAvaG9tZS9uaWFnYXJhL2hnaG9tZS9uZXRj aGFubmVsMi14ZW4tdW5zdGFibGUuaGcvdG9vbHMvaG90cGx1ZycKbWFrZSAtQyBjb21tb24g aW5zdGFsbAptYWtlWzJdOiBFbnRlcmluZyBkaXJlY3RvcnkgYC9ob21lL25pYWdhcmEvaGdo b21lL25ldGNoYW5uZWwyLXhlbi11bnN0YWJsZS5oZy90b29scy9ob3RwbHVnL2NvbW1vbicK WyAtZCAvL2V0Yy94ZW4vc2NyaXB0cyBdIHx8IFwKCQkuLi8uLi8uLi8vdG9vbHMvY3Jvc3Mt aW5zdGFsbCAtZCAtbTA3NTUgLXAgLy9ldGMveGVuL3NjcmlwdHMKc2V0IC1lOyBmb3IgaSBp biA7IFwKCSAgIGRvIFwKCSAgIC4uLy4uLy4uLy90b29scy9jcm9zcy1pbnN0YWxsIC1tMDc1 NSAtcCAkaSAvL2V0Yy94ZW4vc2NyaXB0czsgXAoJZG9uZQpzZXQgLWU7IGZvciBpIGluIDsg XAoJICAgZG8gXAoJICAgLi4vLi4vLi4vL3Rvb2xzL2Nyb3NzLWluc3RhbGwgLW0wNjQ0IC1w ICRpIC8vZXRjL3hlbi9zY3JpcHRzOyBcCglkb25lCm1ha2VbMl06IExlYXZpbmcgZGlyZWN0 b3J5IGAvaG9tZS9uaWFnYXJhL2hnaG9tZS9uZXRjaGFubmVsMi14ZW4tdW5zdGFibGUuaGcv dG9vbHMvaG90cGx1Zy9jb21tb24nCm1ha2VbMV06IExlYXZpbmcgZGlyZWN0b3J5IGAvaG9t ZS9uaWFnYXJhL2hnaG9tZS9uZXRjaGFubmVsMi14ZW4tdW5zdGFibGUuaGcvdG9vbHMvaG90 cGx1ZycKbWFrZVsxXTogRW50ZXJpbmcgZGlyZWN0b3J5IGAvaG9tZS9uaWFnYXJhL2hnaG9t ZS9uZXRjaGFubmVsMi14ZW4tdW5zdGFibGUuaGcvdG9vbHMvaG90cGx1ZycKbWFrZSAtQyBM aW51eCBpbnN0YWxsCm1ha2VbMl06IEVudGVyaW5nIGRpcmVjdG9yeSBgL2hvbWUvbmlhZ2Fy YS9oZ2hvbWUvbmV0Y2hhbm5lbDIteGVuLXVuc3RhYmxlLmhnL3Rvb2xzL2hvdHBsdWcvTGlu dXgnClsgLWQgLy9ldGMvaW5pdC5kIF0gfHwgLi4vLi4vLi4vL3Rvb2xzL2Nyb3NzLWluc3Rh bGwgLWQgLW0wNzU1IC1wIC8vZXRjL2luaXQuZApbIC1kIC8vZXRjL3N5c2NvbmZpZyBdIHx8 IC4uLy4uLy4uLy90b29scy9jcm9zcy1pbnN0YWxsIC1kIC1tMDc1NSAtcCAvL2V0Yy9zeXNj b25maWcKLi4vLi4vLi4vL3Rvb2xzL2Nyb3NzLWluc3RhbGwgLW0wNzU1IC1wIGluaXQuZC94 ZW5kIC8vZXRjL2luaXQuZAouLi8uLi8uLi8vdG9vbHMvY3Jvc3MtaW5zdGFsbCAtbTA3NTUg LXAgaW5pdC5kL3hlbmRvbWFpbnMgLy9ldGMvaW5pdC5kCi4uLy4uLy4uLy90b29scy9jcm9z cy1pbnN0YWxsIC1tMDc1NSAtcCBpbml0LmQvc3lzY29uZmlnLnhlbmRvbWFpbnMgLy9ldGMv c3lzY29uZmlnL3hlbmRvbWFpbnMKWyAtZCAvL2V0Yy94ZW4vc2NyaXB0cyBdIHx8IFwKCQku Li8uLi8uLi8vdG9vbHMvY3Jvc3MtaW5zdGFsbCAtZCAtbTA3NTUgLXAgLy9ldGMveGVuL3Nj cmlwdHMKc2V0IC1lOyBmb3IgaSBpbiBuZXR3b3JrLWJyaWRnZSB2aWYtYnJpZGdlIG5ldHdv cmstcm91dGUgdmlmLXJvdXRlIG5ldHdvcmstbmF0IHZpZi1uYXQgYmxvY2sgYmxvY2stZW5i ZCBibG9jay1uYmQgdnRwbSB2dHBtLWRlbGV0ZSB4ZW4taG90cGx1Zy1jbGVhbnVwIGV4dGVy bmFsLWRldmljZS1taWdyYXRlIHZzY3NpOyBcCgkgICAgZG8gXAoJICAgIC4uLy4uLy4uLy90 b29scy9jcm9zcy1pbnN0YWxsIC1tMDc1NSAtcCAkaSAvL2V0Yy94ZW4vc2NyaXB0czsgXAoJ ZG9uZQpzZXQgLWU7IGZvciBpIGluIHhlbi1zY3JpcHQtY29tbW9uLnNoIGxvY2tpbmcuc2gg bG9nZ2luZy5zaCB4ZW4taG90cGx1Zy1jb21tb24uc2ggeGVuLW5ldHdvcmstY29tbW9uLnNo IHZpZi1jb21tb24uc2ggYmxvY2stY29tbW9uLnNoIHZ0cG0tY29tbW9uLnNoIHZ0cG0taG90 cGx1Zy1jb21tb24uc2ggdnRwbS1taWdyYXRpb24uc2ggdnRwbS1pbXBsOyBcCgkgICAgZG8g XAoJICAgIC4uLy4uLy4uLy90b29scy9jcm9zcy1pbnN0YWxsIC1tMDY0NCAtcCAkaSAvL2V0 Yy94ZW4vc2NyaXB0czsgXAoJZG9uZQpbIC1kIC8vZXRjL3VkZXYgXSB8fCBcCgkJLi4vLi4v Li4vL3Rvb2xzL2Nyb3NzLWluc3RhbGwgLWQgLW0wNzU1IC1wIC8vZXRjL3VkZXYvcnVsZXMu ZApzZXQgLWU7IGZvciBpIGluIHhlbi1iYWNrZW5kLnJ1bGVzIHhlbmQucnVsZXM7IFwKCSAg ICBkbyBcCgkgICAgLi4vLi4vLi4vL3Rvb2xzL2Nyb3NzLWluc3RhbGwgLW0wNjQ0IC1wICRp IC8vZXRjL3VkZXY7IFwKCSAgICBsbiAtc2YgLi4vJGkgLy9ldGMvdWRldi9ydWxlcy5kOyBc Cglkb25lCm1ha2VbMl06IExlYXZpbmcgZGlyZWN0b3J5IGAvaG9tZS9uaWFnYXJhL2hnaG9t ZS9uZXRjaGFubmVsMi14ZW4tdW5zdGFibGUuaGcvdG9vbHMvaG90cGx1Zy9MaW51eCcKbWFr ZVsxXTogTGVhdmluZyBkaXJlY3RvcnkgYC9ob21lL25pYWdhcmEvaGdob21lL25ldGNoYW5u ZWwyLXhlbi11bnN0YWJsZS5oZy90b29scy9ob3RwbHVnJwo= --------------060606080402050300030001 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------060606080402050300030001-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Smith Subject: Re: Experience with netchannel2 Date: Wed, 1 Jul 2009 17:07:43 +0100 Message-ID: <20090701160743.GA16252@weybridge.uk.xensource.com> References: <20090630115331.GA8688@weybridge.uk.xensource.com> <4A4B3438.10206@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1664665305==" Return-path: In-Reply-To: <4A4B3438.10206@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Sergey Tovpeko Cc: Steven Smith , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --===============1664665305== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >> 1. During xen-netchannel2 building, vif2 script > >> tools/hotplug/Linux/vif2 isn't installed to /etc/xen/scripts. > >> Is this script needed at all? > >> =20 > > It is needed, and it should be installed in /etc/xen/scripts. The > > normal tools makefiles are supposed to do this automatically when you > > run ``make install'' (and they do on my test box). Could you post > > the output of ``cd tools/hotplug; make install'', please? > > =20 > I've attached the log in 'hotplug_makefile' file. > It seems that tools/hotplug/Makefile doesn't know that it should place > 'vif2' to /etc/xen/scripts. Ah, yes, sorry about that. It looks like I lost the relevant line of Makefile during one of the merges. Should be fixed by cset 39b6b4761690. > >> What variable should be placed in domU config : 'vif' or 'vif2'? > >> =20 > > vif2. e.g.: > > > > vif2 =3D [ 'bridge=3Deth1' ] > > =20 > Hmm, there is no key 'bridge' for vif2 in tools/python/xen/xm/create.py > And domU doesn't start with > Error: Invalid vif option: bridge >=20 > for c in vifs2: > d =3D comma_sep_kv_to_dict(c) > config_vif =3D ['vif2'] >=20 > for k in d.keys(): > if k not in ['front_mac', 'back_mac', 'backend', 'pdev', > 'max_bypasses']: > err('Invalid vif option: ' + k) > config_vif.append([k, d[k]]) > config_devs.append(['device', config_vif]) Err... yes, sorry again. I plumbed the bridge parameter through for network2-attach, but it looks like I forgot about create. Should be fixed by cset c14cc8002561. > Moreover, the domU is starting without 'bridge' key with > vif2 =3D[ '' ] > but what i have, are > 1. Virtual network interface is created in dom0 with name 'eth1', while > in old netchannel1, virtual network intarface > has the name 'vifN.M'. It's very strange that i have 'eth1' instead of > 'vifN.M'. Is it? It's easy enough to change the name of the interface, but I've never really understood why it was desirable. > 2. Despite the fact that DomU have started, there no connection in domU. > I suppose it's due to the virtual interface have not been attached to > the bridge in Dom0. Yes, that'll have been because the bridge parameter was broken. > I noticed that there are differencies between /etc/xen/scripts/vif and > /etc/xen/scritps/vif2. The old vif uses 'brctl show' command to find the > bridge, but vif2 script doesn't. Yes, the behaviour differs if you don't specify a bridge. vif-bridge picks one at random and attaches the interface to that, whereas vif2 just doesn't attach at all. Neither is really correct. I've now modified the vif2 script so that: -- If you specify a bridge, it uses that. -- If you specify a bridge of ``-'', it leaves the vif hanging. -- If you leave the bridge unspecified, and you only have one in dom0, it uses the only bridge. -- Otherwise, it flags an error. Does that sound sane? That's still not perfect, because it means that creating a new bridge can suddenly make all of your existing domains stop working, but I can't really see any better ways of handling this. > >> 2. I have managed to start domU with netchannel2 succesfully with sing= le virtual ethernet card. > >> But when I added second vif device to the domU configuration, i got b= lack screen in dom0, during > >> domU starting. It happens on the on network initialisation stage, so i= could consider netchannel2 > >> affects this somehow. I didn't dig it yet, but it's critical to me to = have more then one NIC. > >> =20 > > What do you mean by ``black screen''? That dom0 crashes? Is there > > any chance you could get a serial console on it, please? > > =20 > I mean my dom0 is rebooting, tripple fault have been occured. > I'm going to research this problem. Here my test case > 1. Start domU with two netchannel1 NIC > vif =3D [ '', '' ] > 2. In DomU obtain IP-address manually for first NIC, then for second one. > dhclient eth0 > dhclient eth1 >=20 > Before second dhclient finished, dom0 goes to reboot. Got it, thanks. Should be fixed by cset b1779e71b375. I'm sorry this has been more trouble than it should have been. Steven. --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFKS4nPvAgSWYI3DVMRAqmOAKCIeMsY3CmnwVazhHDHfT0JwUtMTgCgwDYz lpPMCfOomLNNKkFAw5yp2fw= =ekKq -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh-- --===============1664665305== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1664665305==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Tovpeko Subject: Re: Experience with netchannel2 Date: Thu, 02 Jul 2009 18:41:48 +0400 Message-ID: <4A4CC72C.7000302@gmail.com> References: <20090630115331.GA8688@weybridge.uk.xensource.com> <4A4B3438.10206@gmail.com> <20090701160743.GA16252@weybridge.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000308080400070608060601" Return-path: In-Reply-To: <20090701160743.GA16252@weybridge.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Steven Smith Cc: Steven Smith , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------000308080400070608060601 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Steven! >> Moreover, the domU is starting without 'bridge' key with >> vif2 =[ '' ] >> but what i have, are >> 1. Virtual network interface is created in dom0 with name 'eth1', while >> in old netchannel1, virtual network intarface >> has the name 'vifN.M'. It's very strange that i have 'eth1' instead of >> 'vifN.M'. >> > Is it? It's easy enough to change the name of the interface, but I've > never really understood why it was desirable. > I'd like to distinguish somehow, that device named 'vif' is virtual network interface for domU, at least for testing purposes. Thank you very much for your efforts and fixes. Please, consider some minor changes in gnttab_request_version I added the return code to it., because HYPERVISOR_grant_table_op could return -EFAULT, -EINVAL additional to -ENOSYS. I attached the file. Sergey Tovpeko. --------------000308080400070608060601 Content-Type: text/x-patch; name="versions.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="versions.diff" diff --git a/drivers/xen/core/gnttab.c b/drivers/xen/core/gnttab.c index 5314932..5f27756 100644 --- a/drivers/xen/core/gnttab.c +++ b/drivers/xen/core/gnttab.c @@ -654,28 +654,31 @@ static inline unsigned int max_nr_grant_frames(void) return xen_max; } -static void gnttab_request_version(void) +static int gnttab_request_version(void) { int rc; struct gnttab_set_version gsv; + int version = 2; - gsv.version = 2; + gsv.version = version; rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv, 1); if (rc == 0) { - grant_table_version = 2; - printk("<0>Grant table version 2.\n"); + grant_table_version = version; + printk("<0>Grant table version %d.\n", grant_table_version); } else { - if (grant_table_version == 2) { + if (rc == -ENOSYS && grant_table_version == 2) { /* If we've already used version 2 features, but then suddenly discover that they're not available (e.g. migrating to an older version of Xen), almost unbounded badness can happen. */ panic("we need grant tables version 2, but only version 1 is available"); + grant_table_version = 1; + printk("<0>Grant table version 1.\n"); + rc = 0; } - grant_table_version = 1; - printk("<0>Grant table version 1.\n"); } + return rc; } #ifdef CONFIG_XEN @@ -1011,7 +1014,10 @@ EXPORT_SYMBOL(gnttab_post_map_adjust); int gnttab_resume(void) { - gnttab_request_version(); + int rc; + + if (rc = gnttab_request_version()) + return rc; if (max_nr_grant_frames() < nr_grant_frames) return -ENOSYS; return gnttab_map(0, nr_grant_frames - 1); @@ -1092,8 +1098,10 @@ int gnttab_resume(void) { unsigned int max_nr_gframes, nr_gframes; unsigned int max_nr_sframes, nr_sframes; + int rc; - gnttab_request_version(); + if (rc = gnttab_request_version()) + return rc; nr_gframes = nr_grant_frames; max_nr_gframes = max_nr_grant_frames(); --------------000308080400070608060601 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------000308080400070608060601-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Smith Subject: Re: Experience with netchannel2 Date: Mon, 6 Jul 2009 11:33:56 +0100 Message-ID: <20090706103356.GA6123@weybridge.uk.xensource.com> References: <20090630115331.GA8688@weybridge.uk.xensource.com> <4A4B3438.10206@gmail.com> <20090701160743.GA16252@weybridge.uk.xensource.com> <4A4CC72C.7000302@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1317966002==" Return-path: In-Reply-To: <4A4CC72C.7000302@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Sergey Tovpeko Cc: Steven Smith , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --===============1317966002== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Thank you very much for your efforts and fixes. > Please, consider some minor changes in gnttab_request_version > I added the return code to it., because HYPERVISOR_grant_table_op could= =20 > return -EFAULT, -EINVAL additional to -ENOSYS. > I attached the file. Hmm. I'm not convinced by this, for a couple of reasons: a) HYPERVISOR_grant_table_op(GNTTABOP_set_version) won't return -EFAULT or -EINVAL for this particular call, because the parameters to the call are correct. b) Even if it did, the current behaviour (of just assuming version 1) is pretty reasonable. c) If gnttab_resume() fails then there isn't really anything which the rest of the kernel can do to recover, so the guest will almost certainly just crash a few instructions later. So I think I'm going to pass on this one. Thanks, Steven. --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFKUdMUvAgSWYI3DVMRAvr9AJ9bgH4Du3BHQjV3/OSCc2HwM0w3LQCePaJv 73Q5T/ZGE7mj3rjz52sLVnA= =BVj3 -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx-- --===============1317966002== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1317966002==--