From: dwalsh@redhat.com (Daniel J Walsh)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] Debian has mailman lock files too
Date: Wed, 01 Jul 2009 12:54:06 -0400 [thread overview]
Message-ID: <4A4B94AE.5070107@redhat.com> (raw)
In-Reply-To: <874otwjuo6.fsf@anzu.internal.golden-gryphon.com>
On 07/01/2009 11:21 AM, Manoj Srivastava wrote:
> diff --git a/policy/modules/services/mailman.fc b/policy/modules/services/mailman.fc
> index 839017f..3199d21 100644
> --- a/policy/modules/services/mailman.fc
> +++ b/policy/modules/services/mailman.fc
> @@ -31,3 +31,8 @@ ifdef(`distro_redhat', `
> /var/lock/mailman(/.*)? gen_context(system_u:object_r:mailman_lock_t,s0)
> /var/spool/mailman(/.*)? gen_context(system_u:object_r:mailman_data_t,s0)
> ')
> +
> +ifdef(`distro_debian', `
> +/var/lock/mailman(/.*)? gen_context(system_u:object_r:mailman_lock_t,s0)
> +')
> +
>
Why not remove the ifdef distro...*
We should not be adding ifdef distro unless the distros conflict on
labels. I don't imagine any distro is going to have /var/lock/mailman
be anything other them mailman_lock_t.
Several times I have had to move a label out of ifdef...debian because
fedora moved to the same labeling.
I think we should add as few ifdef(`disto into fc files as possible.
next prev parent reply other threads:[~2009-07-01 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 15:21 [refpolicy] Debian has mailman lock files too Manoj Srivastava
2009-07-01 16:54 ` Daniel J Walsh [this message]
2009-07-06 18:53 ` Christopher J. PeBenito
2009-07-13 7:08 ` Manoj Srivastava
2009-11-12 3:22 ` Russell Coker
2009-07-14 12:55 ` Christopher J. PeBenito
2009-07-14 17:17 ` [refpolicy] [PATCH] Remove duplicate distro_redhat context Manoj Srivastava
2009-07-15 13:32 ` Christopher J. PeBenito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4B94AE.5070107@redhat.com \
--to=dwalsh@redhat.com \
--cc=refpolicy@oss.tresys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.