From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MM3NR-0001wK-RN
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 13:13:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MM3NN-0001u1-Nk
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 13:13:45 -0400
Received: from [199.232.76.173] (port=32875 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MM3NN-0001ts-Ji
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 13:13:41 -0400
Received: from moutng.kundenserver.de ([212.227.126.177]:51057)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1MM3NN-0003Yi-3R
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 13:13:41 -0400
Message-ID: <4A4B993F.8090900@mail.berlios.de>
Date: Wed, 01 Jul 2009 19:13:35 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel][PATCH] Fix hxtool.
References: <1245499950-13035-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1245499950-13035-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Stefan Weil schrieb:
> When converting from hx to texi format, hxtool (or to be
> more precise sh which interprets hxtool) used standard
> shell expansion of wildcards while writing lines to the
> output.
>
> Thus, something like "Password: ********"
> looked very different in the generated documentation.
>
> The patch disables this unwanted wildcard expansion.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hxtool |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hxtool b/hxtool
> index 885abe2..0fdbc64 100644
> --- a/hxtool
> +++ b/hxtool
> @@ -26,10 +26,10 @@ hxtotexi()
>              STEXI*|ETEXI*) flag=$(($flag^1))
>              ;;
>              DEFHEADING*)
> -            echo $(expr "$str" : "DEFHEADING(\(.*\))")
> +            echo "$(expr "$str" : "DEFHEADING(\(.*\))")"
>              ;;
>              *)
> -            test $flag -eq 1 && echo $str
> +            test $flag -eq 1 && echo "$str"
>              ;;
>          esac
>      done
>   

The patch is still missing in qemu.git. Without it, the next
version of http://www.nongnu.org/qemu/qemu-doc.html
will look bad. ;-)

Regards,

Stefan Weil