All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
	Ingo Molnar <mingo@elte.hu>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: fix trace_print_seq()
Date: Thu, 02 Jul 2009 13:57:01 +0800	[thread overview]
Message-ID: <4A4C4C2D.3040709@cn.fujitsu.com> (raw)
In-Reply-To: <20090701140111.GB5097@nowhere>

>> There have a example:
>> after reboot:
>> # echo kmemtrace > current_tracer
>> # echo 0 > options/kmem_minimalistic
>> # cat trace
>> # tracer: kmemtrace
>> #
>> #
>> Nothing is exported, because the first byte of trace_seq->buffer[ ]
>> is KMEMTRACE_USER_ALLOC.
>> ( the value of KMEMTRACE_USER_ALLOC is zero, seeing
>>   kmemtrace_print_alloc_user() in kernel/trace/kmemtrace.c)
>>
...
> Looks good, thanks.
> 
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> 
> But having a '\0' in a non binary trace looks weird. Why do
> we have such plain KMEMTRACE_USER_ALLOC whereas binary tracing
> is not set, as your example shows it?
> 

Because of this commit:

| commit 42af9054c0eeed09ec58d13ec8bf52d225ebcfcc
| Author: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
| Date:   Mon Mar 23 15:12:26 2009 +0200
|
|    kmemtrace: restore original tracing data binary format, improve ABI

I think we should change it to use trace_event->binary() interface for
binary trace.


  reply	other threads:[~2009-07-02  5:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01  8:50 [PATCH] tracing: fix trace_print_seq() Xiao Guangrong
2009-07-01 14:01 ` Frederic Weisbecker
2009-07-02  5:57   ` Li Zefan [this message]
2009-07-01 14:06 ` [tip:tracing/urgent] tracing: Fix trace_print_seq() tip-bot for Xiao Guangrong
2009-07-01 14:15   ` Pekka Enberg
2009-07-01 14:42 ` tip-bot for Xiao Guangrong
2009-07-02  6:54 ` tip-bot for Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4C4C2D.3040709@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=eduard.munteanu@linux360.ro \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.