From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] [ocfs2-devel] NET_MAX_PAYLOAD_BYTES typo?
Date: Thu, 02 Jul 2009 07:32:23 -0700 [thread overview]
Message-ID: <4A4CC4F7.5030909@oracle.com> (raw)
In-Reply-To: <4A4D32FD.6030005@oracle.com>
TaoMa wrote:
>> I've read fs/ocfs2/dlm/dlmcommon.h to study the structure of dlm_migratable_lockres.
>> However, I may find a typo for the DLM_MIG_LOCKRES_MAX_LEN,
>> the NET_MAX_PAYLOAD_BYTES should be O2NET_MAX_PAYLOAD_BYTES, I think.
>> In comments, the sizeof(net_msg) should be sizeof(o2net_msg) by referring to fs/ocfs2/cluster/tcp.h.
>>
> yeah, NET_MAX_PAYLOAD_BYTES here should be O2NET_MAX_PAYLOAD_BYTES and I
> guess the reason why we never find this error is because we never use
> DLM_MIG_LOCKRES_RESERVED by now.
And if we have not used it by now, chances are we never will. Maybe just
remove it. But let it be for the time being. I'll ask Kurt if he
remembers what
the reasoning was.
> btw, there is another NET_MAX_PAYLOAD_BYTES you forget to change in
> fs/ocfs2/dlm/dlmcommon.h
>
next prev parent reply other threads:[~2009-07-02 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 14:13 [Ocfs2-devel] [PATCH 1/1] [ocfs2-devel] NET_MAX_PAYLOAD_BYTES typo? Jeff Liu
2009-07-02 22:21 ` TaoMa
2009-07-02 14:32 ` Sunil Mushran [this message]
2009-07-02 14:35 ` jeff.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4CC4F7.5030909@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.