All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: lizf@cn.fujitzu.com, serue@us.ibm.com, akpm@linux-foundation.org,
	containers@lists.linux-foundation.org, bblum@google.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] CGroups: cgroup member list enhancement/fix
Date: Fri, 03 Jul 2009 09:15:04 +0800	[thread overview]
Message-ID: <4A4D5B98.6000509@cn.fujitsu.com> (raw)
In-Reply-To: <20090702231814.3969.44308.stgit@menage.mtv.corp.google.com>

Paul Menage wrote:
> The following series (written by Ben Blum) adds a "cgroup.procs" file

This is rather useful. :)

> to each cgroup that reports unique tgids rather than pids, and fixes a
> pid namespace bug in the existing "tasks" file that could cause
> readers in different namespaces to interfere with one another.
> 
> The patches as a pair provide similar functionality to Li Zefan's
> patch posted yesterday, with the addition on the "cgroup.procs" file;
> if it's decided that Li's patch needs to be fast-tracked to 2.6.31,
> then these patches can be rebased as a small extension of Li's patch;
> if Li'z patch doesn't need to go to 2.6.31 then it makes more sense to
> take this pair since they provide more overall functionality.
> 

I'd prefer fixing it for 2.6.31. There is no reason we don't fix it
earlier than later. Base a fix on top of a new feature is no good,
and it makes backporting the fix harder if someone wants to do this.


  parent reply	other threads:[~2009-07-03  1:14 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 23:26 [PATCH 0/2] CGroups: cgroup member list enhancement/fix Paul Menage
     [not found] ` <20090702231814.3969.44308.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-07-02 23:26   ` [PATCH 1/2] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Paul Menage
2009-07-02 23:26     ` Paul Menage
     [not found]     ` <20090702232620.3969.16680.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-07-02 23:46       ` Andrew Morton
2009-07-02 23:46         ` Andrew Morton
2009-07-03  0:31         ` Benjamin Blum
2009-07-03  0:53           ` Andrew Morton
2009-07-03  1:08             ` Paul Menage
2009-07-03  1:17               ` Benjamin Blum
2009-07-03  2:08                 ` Andrew Morton
     [not found]                   ` <20090702190845.0cafc46a.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-03  4:16                     ` Paul Menage
2009-07-03  4:16                       ` Paul Menage
2009-07-03  6:55                       ` Andrew Morton
2009-07-03  7:54                         ` KAMEZAWA Hiroyuki
     [not found]                         ` <20090702235527.7ddc873c.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-03  7:54                           ` KAMEZAWA Hiroyuki
2009-07-03 16:11                           ` Paul Menage
2009-07-03 16:11                         ` Paul Menage
2009-07-03 16:50                           ` Andrew Morton
2009-07-03 17:54                             ` Paul Menage
     [not found]                               ` <6599ad830907031054x74d90149y38aae60afa403d58-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-03 18:10                                 ` Andrew Morton
2009-07-03 18:10                                   ` Andrew Morton
     [not found]                                   ` <20090703111016.ceb28541.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-15  8:33                                     ` Eric W. Biederman
2009-07-15  8:33                                   ` Eric W. Biederman
2009-07-15 16:18                                     ` Paul Menage
     [not found]                                     ` <m1ocrm73cu.fsf-+imSwln9KH6u2/kzUuoCbdi2O/JbrIOy@public.gmane.org>
2009-07-15 16:18                                       ` Paul Menage
     [not found]                             ` <20090703095000.cf46ad19.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-03 17:54                               ` Paul Menage
     [not found]                           ` <6599ad830907030911m6176dc59id3a7d897b03d2bd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-03 16:50                             ` Andrew Morton
     [not found]                       ` <6599ad830907022116n7a711c7fs52ff9b400ec8797f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-03  6:55                         ` Andrew Morton
2009-07-03  2:25                 ` Matt Helsley
2009-07-03  3:49                   ` Paul Menage
     [not found]                   ` <20090703022553.GJ19135-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-07-03  3:49                     ` Paul Menage
2009-07-03  7:08                     ` Benjamin Blum
2009-07-03  7:08                   ` Benjamin Blum
     [not found]                 ` <2f86c2480907021817o79fce75yd9785aab682f7bb4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-03  2:08                   ` Andrew Morton
2009-07-03  2:25                   ` Matt Helsley
     [not found]               ` <6599ad830907021808o6f3bb51eh324e4bf13544d83e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-03  1:17                 ` Benjamin Blum
2009-07-03  1:30                 ` Andrew Morton
2009-07-03  1:30               ` Andrew Morton
2009-07-03  5:54                 ` KAMEZAWA Hiroyuki
     [not found]                   ` <20090703145441.f526793f.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-07-03 15:52                     ` Paul Menage
2009-07-03 15:52                   ` Paul Menage
     [not found]                     ` <6599ad830907030852p2cd667e3m353d68448e0cdc6a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-04  2:07                       ` KAMEZAWA Hiroyuki
2009-07-04  2:07                         ` KAMEZAWA Hiroyuki
     [not found]                         ` <3f9558558c68d9e2fe00f7c7681c3764.squirrel-n3SY6/QrmYVJe+uFzlzAcYO9/linGGC/AL8bYrjMMd8@public.gmane.org>
2009-07-04 16:10                           ` Paul Menage
2009-07-04 16:10                         ` Paul Menage
2009-07-05 23:53                           ` KAMEZAWA Hiroyuki
     [not found]                           ` <6599ad830907040910k5c9d720bqafdf596bbc005783-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-05 23:53                             ` KAMEZAWA Hiroyuki
     [not found]                 ` <20090702183004.1e3f4315.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-03  5:54                   ` KAMEZAWA Hiroyuki
     [not found]             ` <20090702175341.fd2e26d5.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-03  1:08               ` Paul Menage
     [not found]           ` <2f86c2480907021731h13e0bb95q94f06829eded9aa6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-03  0:53             ` Andrew Morton
     [not found]         ` <20090702164649.303c4952.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-03  0:31           ` Benjamin Blum
2009-07-02 23:26   ` [PATCH 2/2] Ensures correct concurrent opening/reading of pidlists across pid namespaces Paul Menage
2009-07-02 23:26     ` Paul Menage
     [not found]     ` <20090702232625.3969.54444.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-07-02 23:54       ` Andrew Morton
2009-07-02 23:54         ` Andrew Morton
2009-07-03  0:43         ` Benjamin Blum
     [not found]         ` <20090702165413.f4a21471.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-07-03  0:22           ` Paul Menage
2009-07-03  0:22             ` Paul Menage
2009-07-03  0:26             ` Paul Menage
     [not found]             ` <6599ad830907021722x7b012991i1eca056bc72c010c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-03  0:26               ` Paul Menage
2009-07-03  0:43           ` Benjamin Blum
2009-07-03  1:15   ` [PATCH 0/2] CGroups: cgroup member list enhancement/fix Li Zefan
2009-07-05  6:38   ` Balbir Singh
2009-07-03  1:15 ` Li Zefan [this message]
2009-07-05  6:38 ` Balbir Singh
2009-07-10 23:58   ` Paul Menage
     [not found]     ` <6599ad830907101658i13e4046br70377a487dd6b49b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-13 12:11       ` Balbir Singh
2009-07-13 12:11     ` Balbir Singh
2009-07-13 16:26       ` Paul Menage
     [not found]         ` <6599ad830907130926v7788af12hdcd76e4ccb3ab6de-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-14  5:56           ` Balbir Singh
2009-07-14  5:56         ` Balbir Singh
     [not found]           ` <20090714055638.GI5051-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-07-14  6:49             ` Paul Menage
2009-07-14  6:49           ` Paul Menage
     [not found]             ` <6599ad830907132349u6cf52060t4fafb6637cbe4ed1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-14  7:16               ` Balbir Singh
2009-07-14  7:16             ` Balbir Singh
2009-07-14 17:34               ` Benjamin Blum
2009-07-14 17:43                 ` Paul Menage
2009-07-14 20:38                   ` Paul Menage
     [not found]                     ` <6599ad830907141338t794e60admf81807b381c46e41-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-14 23:08                       ` Matt Helsley
2009-07-14 23:08                     ` Matt Helsley
     [not found]                   ` <6599ad830907141043s1c16d5c9saad9118c210ecef4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-14 20:38                     ` Paul Menage
     [not found]                 ` <2f86c2480907141034r5a985cfue9e8fdf64ad28465-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-14 17:43                   ` Paul Menage
     [not found]               ` <20090714071617.GK5051-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-07-14 17:34                 ` Benjamin Blum
     [not found]       ` <20090713121138.GC5051-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-07-13 16:26         ` Paul Menage
     [not found]   ` <20090705063850.GX11273-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2009-07-10 23:58     ` Paul Menage
  -- strict thread matches above, loose matches on Subject: below --
2009-07-02 23:26 Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4D5B98.6000509@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=bblum@google.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitzu.com \
    --cc=menage@google.com \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.