Re: [Autotest] [PATCH] Add a client-side test qemu_iotests

[Yolkfull Chow <yzhou@redhat.com>]

On 07/03/2009 01:03 PM, Lucas Meneghel Rodrigues wrote:
> On Thu, 2009-07-02 at 21:23 -0300, Lucas Meneghel Rodrigues wrote:
>    
>> Ok, I've been trough the test and took a look at the testsuite itself.
>> Both look good. The testsuite requires a very current qemu-img package,
>> due to the use of qemu-io (F11 for instance doesn't ship it). So if you
>> want to try this make sure you use a current version of the kvm
>> utilities.
>>      
> It just occurred to me some suggestions based on my last comment:
>   * Make sure we have the qemu, qemu-img and the qemu-io ELF files
> available to execute the test suite, and if we doesn't, raise a
> error.TestError() exception.
>    
I modified.
>   * Make it possible to specify an alternate prefix to look for those
> ELFs, and make sure the test suite can find them (ie, appending the path
> to os.environ['PATH']).
>    
Lucas, do we really need to find those ELFs within the whole disk if 
they are not in os.environ['PATH']?  That's not testsuite's purpose I 
think.

What's your opinion?
> Yolkfull, please take a look at implementing those suggestions.
>
> Thanks again for your work!
>
> Lucas
>
>    


-- 
Yolkfull
Regards,