From: Eric Dumazet <eric.dumazet@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
mingo@elte.hu, jolsa@redhat.com, a.p.zijlstra@chello.nl,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
fbl@redhat.com, nhorman@redhat.com, davem@redhat.com,
htejun@gmail.com, jarkao2@gmail.com, oleg@redhat.com,
davidel@xmailserver.org, eric.dumazet@gmail.com,
Paul.McKenney@us.ibm.com
Subject: Re: [PATCHv5 2/2] memory barrier: adding smp_mb__after_lock
Date: Fri, 03 Jul 2009 17:37:31 +0200 [thread overview]
Message-ID: <4A4E25BB.8060408@gmail.com> (raw)
In-Reply-To: <20090703152951.GA28837@gondor.apana.org.au>
Herbert Xu a écrit :
> Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
>> Why don't we create a read_lock without acquire semantic instead (e.g.
>> read_lock_nomb(), or something with a better name like __read_lock()) ?
>> On architectures where memory barriers are needed to provide the acquire
>> semantic, it would be faster to do :
>>
>> __read_lock();
>> smp_mb();
>>
>> than :
>>
>> read_lock(); <- e.g. lwsync + isync or something like that
>> smp_mb(); <- full sync.
>
> Hmm, why do we even care when read_lock should just die?
>
> Cheers,
+1 :)
Do you mean using a spinlock instead or what ?
Also, how many arches are able to have a true __read_lock()
(or __spin_lock() if that matters), without acquire semantic ?
next prev parent reply other threads:[~2009-07-03 15:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 8:12 [PATCHv5 0/2] net: fix race in the receive/select Jiri Olsa
2009-07-03 8:13 ` [PATCHv5 1/2] net: adding memory barrier to the poll and receive callbacks Jiri Olsa
2009-07-07 15:56 ` Eric Dumazet
2009-07-03 8:14 ` [PATCHv5 2/2] memory barrier: adding smp_mb__after_lock Jiri Olsa
2009-07-03 9:06 ` Ingo Molnar
2009-07-03 9:20 ` Eric Dumazet
2009-07-03 9:24 ` Ingo Molnar
2009-07-03 9:56 ` Jiri Olsa
2009-07-03 10:25 ` Ingo Molnar
2009-07-03 11:18 ` Jiri Olsa
2009-07-03 11:30 ` Jarek Poplawski
2009-07-03 11:43 ` Jiri Olsa
2009-07-07 10:18 ` Jiri Olsa
2009-07-07 13:46 ` Jiri Olsa
2009-07-07 14:01 ` Mathieu Desnoyers
2009-07-07 14:34 ` Oleg Nesterov
2009-07-07 15:04 ` Mathieu Desnoyers
2009-07-07 15:44 ` Oleg Nesterov
2009-07-07 15:50 ` Peter Zijlstra
2009-07-07 19:45 ` Mathieu Desnoyers
2009-07-07 22:44 ` Eric Dumazet
2009-07-07 23:28 ` Mathieu Desnoyers
2009-07-07 23:51 ` Oleg Nesterov
2009-07-08 4:34 ` Mathieu Desnoyers
2009-07-08 7:18 ` Jarek Poplawski
2009-07-07 14:34 ` Jiri Olsa
2009-07-07 14:42 ` Eric Dumazet
2009-07-07 14:57 ` Mathieu Desnoyers
2009-07-07 15:23 ` Eric Dumazet
2009-07-08 17:47 ` Jiri Olsa
2009-07-08 18:07 ` David Miller
2009-07-08 18:16 ` Jiri Olsa
2009-07-03 14:04 ` Mathieu Desnoyers
2009-07-03 15:29 ` Herbert Xu
2009-07-03 15:37 ` Eric Dumazet [this message]
2009-07-03 15:47 ` Mathieu Desnoyers
2009-07-03 17:06 ` Paul E. McKenney
2009-07-03 17:31 ` Mathieu Desnoyers
2009-07-03 15:40 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4E25BB.8060408@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Paul.McKenney@us.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=davem@redhat.com \
--cc=davidel@xmailserver.org \
--cc=fbl@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=htejun@gmail.com \
--cc=jarkao2@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.