From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 98846d7] Fix Sparse warning
Date: Sun, 05 Jul 2009 12:00:37 +0300 [thread overview]
Message-ID: <4A506BB5.4010602@redhat.com> (raw)
In-Reply-To: <200907050826.n658QVBa024976@d03av04.boulder.ibm.com>
On 07/05/2009 11:28 AM, Anthony Liguori wrote:
> From: Blue Swirl<blauwirbel@gmail.com>
>
> Signed-off-by: Blue Swirl<blauwirbel@gmail.com>
>
> diff --git a/hw/msix.c b/hw/msix.c
> index 4ab6da6..c031842 100644
> --- a/hw/msix.c
> +++ b/hw/msix.c
> @@ -296,8 +296,9 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
> {
> unsigned n = dev->msix_entries_nr;
>
> - if (!dev->cap_present& QEMU_PCI_CAP_MSIX)
> + if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) {
> return;
> + }
>
>
This is more than a sparse warning fix; it fixes a genuine bug.
--
error compiling committee.c: too many arguments to function
parent reply other threads:[~2009-07-05 8:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200907050826.n658QVBa024976@d03av04.boulder.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A506BB5.4010602@redhat.com \
--to=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.