From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] avoid redeliver of edge interrupt before next edge
Date: Sun, 05 Jul 2009 18:58:09 +0300 [thread overview]
Message-ID: <4A50CD91.8070407@redhat.com> (raw)
In-Reply-To: <1246808892-2179-1-git-send-email-gleb@redhat.com>
On 07/05/2009 06:48 PM, Gleb Natapov wrote:
> The check for an edge is broken in current ioapic code. ioapic->irr is
> cleared on each edge interrupt by ioapic_service() and this makes
> old_irr != ioapic->irr condition in kvm_ioapic_set_irq() to be always
> true. The patch fixes the code to properly recognise edge.
>
> Some HW emulation calls set_irq() without level change. If each such
> call is propagated to an OS it may confuse a device driver. This is the
> case with keyboard device emulation and WindowsXP installer on SMP VM.
> Each button stroke produce two interrupts (down/up) one interrupt is
> submitted to CPU0 and another to CPU1. This confuses Windows somehow
> and it ignores button strokes.
>
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> ---
>
> Same patch as before but split in two. First one fixes bug, second
> make cosmetic changes.
>
>
Applied both, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-07-05 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 15:48 [PATCH 1/2] avoid redeliver of edge interrupt before next edge Gleb Natapov
2009-07-05 15:48 ` [PATCH 2/2] Use temporary variable to shorten lines Gleb Natapov
2009-07-05 15:58 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A50CD91.8070407@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.