From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
skuribay@ruby.dti.ne.jp, trivial@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Trivial: Fix filenames in their headers for the EMMA Mark-eins.
Date: Mon, 06 Jul 2009 09:12:39 +0900 [thread overview]
Message-ID: <4A514177.4000505@necel.com> (raw)
In-Reply-To: <20090705223051.GA18858@linux-mips.org>
Ralf Baechle wrote:
> Different suggestion - let's remove these comment lines entirely. I just
> don't see any use for them. So this patch removes them along with a few
> very obvious comments.
I like this one.
> arch/mips/dec/ecc-berr.c | 2 --
> arch/mips/dec/int-handler.S | 2 --
> arch/mips/dec/ioasic-irq.c | 2 --
> arch/mips/dec/kn01-berr.c | 2 --
> arch/mips/dec/kn02-irq.c | 2 --
> arch/mips/dec/kn02xa-berr.c | 2 --
> arch/mips/dec/prom/call_o32.S | 2 --
> arch/mips/dec/prom/console.c | 2 --
> arch/mips/dec/time.c | 2 --
> arch/mips/emma/common/Makefile | 3 ---
> arch/mips/emma/common/prom.c | 3 ---
> arch/mips/emma/markeins/Makefile | 3 ---
> arch/mips/emma/markeins/irq.c | 3 ---
> arch/mips/emma/markeins/led.c | 3 ---
> arch/mips/emma/markeins/platform.c | 3 ---
> arch/mips/emma/markeins/setup.c | 3 ---
How about arch/mips/fw/lib/call_o32.S?
> arch/mips/include/asm/emma/emma2rh.h | 3 ---
> arch/mips/include/asm/emma/markeins.h | 3 ---
> arch/mips/kernel/irq_txx9.c | 2 --
> arch/mips/kernel/proc.c | 2 --
> arch/mips/kernel/stacktrace.c | 2 --
> arch/mips/mm/extable.c | 3 ---
> arch/mips/pci/fixup-emma2rh.c | 3 ---
> arch/mips/pci/fixup-sb1250.c | 2 --
> arch/mips/pci/ops-emma2rh.c | 3 ---
> arch/mips/pci/pci-emma2rh.c | 3 ---
> arch/mips/pci/pci-tx4927.c | 2 --
> arch/mips/pci/pci-tx4938.c | 2 --
> arch/mips/pci/pci-tx4939.c | 2 --
> arch/mips/pmc-sierra/msp71xx/gpio.c | 2 --
> arch/mips/pmc-sierra/msp71xx/gpio_extended.c | 2 --
> arch/mips/pmc-sierra/yosemite/atmel_read_eeprom.c | 2 --
> arch/mips/sibyte/swarm/swarm-i2c.c | 2 --
> arch/mips/txx9/generic/mem_tx4927.c | 2 --
> arch/mips/txx9/generic/setup.c | 2 --
> 35 files changed, 0 insertions(+), 83 deletions(-)
[...]
> diff --git a/arch/mips/mm/extable.c b/arch/mips/mm/extable.c
> index 297fb9f..e94ea59 100644
> --- a/arch/mips/mm/extable.c
> +++ b/arch/mips/mm/extable.c
> @@ -1,6 +1,3 @@
> -/*
> - * linux/arch/mips/mm/extable.c
> - */
> #include <linux/module.h>
> #include <linux/spinlock.h>
> #include <asm/branch.h>
Btw, let's have extable.c have, at least, a copyright later.
Acked-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
--
Shinya Kuribayashi
NEC Electronics
next prev parent reply other threads:[~2009-07-06 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 22:30 [PATCH 1/3] Trivial: Fix filenames in their headers for the EMMA Mark-eins Thadeu Lima de Souza Cascardo
2009-07-04 22:47 ` Shinya Kuribayashi
2009-07-05 22:30 ` Ralf Baechle
2009-07-06 0:12 ` Shinya Kuribayashi [this message]
2009-07-06 2:23 ` Thadeu Lima de Souza Cascardo
2009-07-06 8:23 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A514177.4000505@necel.com \
--to=shinya.kuribayashi@necel.com \
--cc=cascardo@holoscopio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=skuribay@ruby.dti.ne.jp \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.