From: gowrishankar <gomuthuk@linux.vnet.ibm.com>
To: subrata@linux.vnet.ibm.com
Cc: ltp-list@lists.sf.net
Subject: [LTP] [PATCH] cgroups: conditionally enable building cgroup tests
Date: Mon, 06 Jul 2009 15:45:56 +0530 [thread overview]
Message-ID: <4A51CEDC.6080605@linux.vnet.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
Hi Subrata,
Please accept the patch below.
Thanks,
Gowri
---
cgroups: conditionally enable building cgroup tests
controllers tests gets included into default ltp build if "/proc/cgroup"
exists. It stops the ltp build in realtime kernel environment where kernel
is new and supports cgroups, but necessary file "linux/cgroupstats.h" may not
exist in the base OS (like RHEL5.3). So configure command enables the build,
but actual build fails, due to missing header file.
Below patch proposes new symbol LTP_CHECK_CGROUPSTATS to check for header file
"linux/cgroupstats.h" and include controllers in the list of tests to build.
Tested the patch in non-RT as well as RT environment for the changes.
Signed-off-by: Gowrishankar <gowrishankar.m@in.ibm.com>
Tested-by: Gowrishankar <gowrishankar.m@in.ibm.com>
---
[-- Attachment #2: controllers-build.patch --]
[-- Type: text/x-patch, Size: 1608 bytes --]
Index: ltp-full-20090630/m4/ltp-cgroupstats.m4
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ ltp-full-20090630/m4/ltp-cgroupstats.m4 2009-07-03 13:41:55.000000000 +0530
@@ -0,0 +1,9 @@
+dnl
+dnl LTP_CHECK_CGROUPSTATS
+dnl ----------------------------
+dnl
+AC_DEFUN([LTP_CHECK_CGROUPSTATS],
+[dnl
+AC_CHECK_HEADERS(linux/cgroupstats.h,[LTP_CHECK_CGROUPSTATS_HEADER=yes])
+AC_SUBST(LTP_CHECK_CGROUPSTATS_HEADER)
+])
Index: ltp-full-20090630/configure.ac
===================================================================
--- ltp-full-20090630.orig/configure.ac 2009-07-03 13:59:48.000000000 +0530
+++ ltp-full-20090630/configure.ac 2009-07-03 14:00:14.000000000 +0530
@@ -21,5 +21,6 @@
LTP_CHECK_SELINUX
LTP_CHECK_CRYPTO
LTP_CHECK_TASKSTATS
+LTP_CHECK_CGROUPSTATS
AC_OUTPUT
Index: ltp-full-20090630/testcases/kernel/Makefile
===================================================================
--- ltp-full-20090630.orig/testcases/kernel/Makefile 2009-07-03 14:01:25.000000000 +0530
+++ ltp-full-20090630/testcases/kernel/Makefile 2009-07-03 14:02:42.000000000 +0530
@@ -1,6 +1,12 @@
-SUBDIRS = power_management numa containers controllers connectors include fs io ipc mem pty sched security syscalls timers
+include ../../config.mk
+
+SUBDIRS = power_management numa containers connectors include fs io ipc mem pty sched security syscalls timers
UCLINUX_SUBDIRS = include syscalls
+ifeq ($(LTP_CHECK_CGROUPSTATS_HEADER),yes)
+ SUBDIRS+= controllers
+endif
+
all:
@set -e; for i in $(SUBDIRS); do $(MAKE) -C $$i ; done
[-- Attachment #3: Type: text/plain, Size: 79 bytes --]
------------------------------------------------------------------------------
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2009-07-06 10:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 10:15 gowrishankar [this message]
2009-07-06 11:38 ` [LTP] [PATCH] cgroups: conditionally enable building cgroup tests Francesco RUNDO
2009-07-06 12:00 ` gowrishankar
2009-07-06 12:42 ` Francesco RUNDO
2009-07-06 12:55 ` Subrata Modak
2009-07-06 13:05 ` Francesco RUNDO
2009-07-06 17:22 ` Garrett Cooper
2009-07-06 17:28 ` Garrett Cooper
2009-07-06 22:06 ` Mike Frysinger
2009-07-07 6:58 ` Francesco RUNDO
2009-07-07 14:24 ` Mike Frysinger
2009-07-08 7:40 ` Francesco RUNDO
2009-07-07 6:53 ` Francesco RUNDO
2009-07-07 9:11 ` Garrett Cooper
2009-07-06 15:51 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A51CEDC.6080605@linux.vnet.ibm.com \
--to=gomuthuk@linux.vnet.ibm.com \
--cc=ltp-list@lists.sf.net \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.