From: Dave <kilroyd@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: fix giwrange
Date: Mon, 06 Jul 2009 18:36:09 +0100 [thread overview]
Message-ID: <4A523609.5070409@gmail.com> (raw)
In-Reply-To: <1246828399.4411.7.camel@johannes.local>
Johannes Berg wrote:
> commit c4c496e49ddbf022e51adbd25cedd071329280db
> Author: David Kilroy <kilroyd@googlemail.com>
> Date: Thu Jun 18 23:21:14 2009 +0100
>
> cfg80211: Advertise ciphers via WE according to driver capability
>
> unfortunately broke iwrange -- it used the variable c
> that needs to be 0 for the channel list.
Doh! I distinctly recall wonderring whether I should use a separate
variable. Must've got side-tracked. Sorry :(
Just one thing about the fix though...
> @@ -201,7 +201,7 @@ int cfg80211_wext_giwrange(struct net_de
> range->avg_qual.noise = range->max_qual.noise / 2;
> range->avg_qual.updated = range->max_qual.updated;
>
> - for (c = 0; c < wdev->wiphy->n_cipher_suites; c++) {
> + for (i = 0; i < wdev->wiphy->n_cipher_suites; i++) {
> switch (wdev->wiphy->cipher_suites[c]) {
^ needs to be i
Dave.
next prev parent reply other threads:[~2009-07-06 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 21:13 [PATCH] cfg80211: fix giwrange Johannes Berg
2009-07-06 17:36 ` Dave [this message]
2009-07-06 17:40 ` Johannes Berg
2009-07-06 17:40 ` [PATCH v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A523609.5070409@gmail.com \
--to=kilroyd@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.