From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?SmVhbi1QaWVycmUgQW5kcsOp?= Subject: Re: [PATCH] fuse: allow umask processing in userspace Date: Mon, 06 Jul 2009 20:52:41 +0200 Message-ID: <4A5247F9.5090805@wanadoo.fr> References: <20090618093635.GQ17358@hasgksssven.desy.de> <4A3BC22A.80907@wanadoo.fr> <4A4F6C64.4020800@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: utcke+fuse@informatik.uni-hamburg.de, fuse-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, szaka@ntfs-3g.com To: Miklos Szeredi Return-path: Received: from smtp20.orange.fr ([80.12.242.27]:51711 "EHLO smtp20.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274AbZGFSwk convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2009 14:52:40 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Miklos, Miklos Szeredi wrote: > On Sat, 04 Jul 2009, Jean-Pierre Andr=C3=A9 wrote: > =20 >> I went through the patches and the tests, and I can >> announce that ntfs-3g is the first fuse-based file system >> which passes the PJD Posix test fully, including the >> Posix ACL parts. >> =20 > > Thanks for testing. > > =20 [...] >> There is just a point which worries me : I cannot understand >> how your client patch deactivates the old code which was >> applying the umask. I would prefer not to discover it the >> hard way... >> =20 > > The > > sb->s_flags |=3D MS_POSIXACL; > > line tells the VFS that it should leave umask applying to the > filesystem. The flag is misnamed, it really should be "MS_NOMASK" or > something. > =20 So there it was, relying on a safe condition... Thanks so much. Jean-Pierre -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html